maggicl/va02-part3
Archived
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

implemented plugin and unit tests

Browse source
This commit is contained in:
Claudio Maggioni 2023-05-02 18:08:27 +02:00
parent 0df28bc0b9
commit b4e6209f9a
3 changed files with 113 additions and 40 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

66
src/main/java/usi/vaa/elasticsearch/plugin/ingest/lookup/LookupProcessor.java
View file

@ -17,59 +17,77 @@
package usi.vaa.elasticsearch.plugin.ingest.lookup;
import org.elasticsearch.common.Strings;
import org.elasticsearch.ingest.AbstractProcessor;
import org.elasticsearch.ingest.IngestDocument;
import org.elasticsearch.ingest.Processor;
import java.io.IOException;
import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
import java.util.regex.MatchResult;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import static org.elasticsearch.ingest.ConfigurationUtils.readMap;
import static org.elasticsearch.ingest.ConfigurationUtils.readStringProperty;
public class LookupProcessor extends AbstractProcessor {
public static final String FIELD_PROPERTY = "field";
public static final String LOOKUP_MAP_PROPERTY = "lookup-map";
public static final String TYPE = "lookup";
private static final Pattern PATTERN = Pattern.compile("([^\\s\\p{Z}]+)([\\s\\p{Z}]+|$)");
private final String field;
private final Map<String, Object> lookupMap;
private final String field = "";
// TODO this signature and method might be incomplete - change as needed
public LookupProcessor(String tag, String description, String field,
Map<String,String> lookupMap) throws IOException {
public LookupProcessor(String tag, String description, String field, Map<String, String> lookupMap) {
super(tag, description);
this.field = field;
this.lookupMap = new HashMap<>(lookupMap);
}
private String replaceWord(final MatchResult toReplace) {
if (toReplace.groupCount() != 2) {
throw new IllegalArgumentException("Captured groups should be coherent with PATTERN regex");
}
final String word = toReplace.group(1);
final String spacesAfterWord = toReplace.group(2);
return lookupMap.getOrDefault(word, word) + spacesAfterWord;
}
@Override
public IngestDocument execute(IngestDocument ingestDocument) throws Exception{
String originalContent = ingestDocument.getFieldValue(field, String.class);
ingestDocument.setFieldValue(field, "Hello world");
return null;
public IngestDocument execute(IngestDocument ingestDocument) {
final String originalContent = ingestDocument.getFieldValue(field, String.class);
final Matcher matcher = PATTERN.matcher(originalContent);
final String replacedContent = matcher.replaceAll(this::replaceWord);
ingestDocument.setFieldValue(field, replacedContent);
return ingestDocument;
}
@Override
public String getType() {
// TODO your job!
return null;
return TYPE;
}
String getField() {
// TODO your job!
return null;
return this.field;
}
Map<String, Object> getLookupMap() {
return Collections.unmodifiableMap(lookupMap);
}
public static final class Factory implements Processor.Factory {
@Override
public LookupProcessor create(Map<String, Processor.Factory> factories, String tag,
String description, Map<String, Object> config)
throws Exception {
String field = readStringProperty(TYPE, tag, config, "field");
// TODO your job! Also initialize the lookup processor properly if needed, after you changed the constructor
return null;
public LookupProcessor create(final Map<String, Processor.Factory> factories,
final String tag,
final String description,
final Map<String, Object> config) {
final String field = readStringProperty(TYPE, tag, config, FIELD_PROPERTY);
final Map<String, String> lookupMap = readMap(TYPE, tag, config, LOOKUP_MAP_PROPERTY);
return new LookupProcessor(tag, description, field, lookupMap);
}
}
}

40
src/test/java/usi/vaa/elasticsearch/plugin/ingest/lookup/LookupProcessorFactoryTests.java
View file

@ -24,25 +24,47 @@ import org.junit.BeforeClass;
import java.util.HashMap;
import java.util.Map;
import static org.hamcrest.Matchers.equalTo;
import static usi.vaa.elasticsearch.plugin.ingest.lookup.LookupProcessor.*;
public class LookupProcessorFactoryTests extends ESTestCase {
private static String tag;
private static String description;
private static LookupProcessor.Factory factory;
@BeforeClass
public static void defaultSettings() {
// TODO your job!
tag = "lookup-test";
description = "lookup pipeline test";
factory = new LookupProcessor.Factory();
}
private Map<String, Object> getDefaultConfig() {
// TODO your job!
private LookupProcessor callFactory(final Map<String, Object> config) {
// if the `config` map is not cloned here java.lang.UnsupportedOperationException is thrown
// for some reflective magic related reason, therefore do not remove
return factory.create(null, tag, description, new HashMap<>(config));
}
public void testDefaultConfiguration() throws Exception{
// TODO your job!
public void testDefaultConfiguration() {
final String testField = "theTestField";
final Map<String, String> testMap = Map.of(
"C001", "tyre",
"C010", "front wing",
"C100", "damper"
);
final Map<String, Object> config = Map.of(
FIELD_PROPERTY, testField,
LOOKUP_MAP_PROPERTY, testMap
);
final LookupProcessor processor = callFactory(config);
assertEquals(tag, processor.getTag());
assertEquals(description, processor.getDescription());
assertEquals(testMap, processor.getLookupMap());
assertEquals(testField, processor.getField());
}
public void testInvalidConfiguration() throws Exception{
// TODO your job!
public void testInvalidConfiguration() {
expectThrows(ElasticsearchParseException.class, () -> callFactory(Map.of("invalid", "config")));
}
}

47
src/test/java/usi/vaa/elasticsearch/plugin/ingest/lookup/LookupProcessorTests.java
View file

@ -22,25 +22,58 @@ import org.elasticsearch.ingest.IngestDocument;
import org.elasticsearch.ingest.RandomDocumentPicks;
import org.elasticsearch.test.ESTestCase;
import org.junit.BeforeClass;
import java.util.HashMap;
import java.util.Map;
import static org.hamcrest.Matchers.equalTo;
import static usi.vaa.elasticsearch.plugin.ingest.lookup.LookupProcessor.FIELD_PROPERTY;
import static usi.vaa.elasticsearch.plugin.ingest.lookup.LookupProcessor.LOOKUP_MAP_PROPERTY;
public class LookupProcessorTests extends ESTestCase {
private static final String DOC_FIELD = "field_to_replace";
private static LookupProcessor processor;
@BeforeClass
public static void defaultSettings() {
// TODO your job!
processor = new LookupProcessor.Factory().create(
null,
"test-lookup",
"Test lookup processor pipeline",
new HashMap<>(Map.of(
FIELD_PROPERTY, DOC_FIELD,
LOOKUP_MAP_PROPERTY, Map.of(
"C001", "tyre",
"C010", "front wing",
"C100", "damper"
)
))
);
}
public void testSimple() throws Exception{
// TODO your job!
private IngestDocument getDocWithContent(final String content) {
final Map<String, Object> doc = Map.of(DOC_FIELD, content);
return RandomDocumentPicks.randomIngestDocument(random(), doc);
}
public void testEmptyField() throws Exception{
// TODO your job!
private void testWithContent(final String originalContent, final String expectedContent) {
final IngestDocument doc = getDocWithContent(originalContent);
processor.execute(doc);
assertEquals(expectedContent, doc.getSourceAndMetadata().get(DOC_FIELD));
}
public void testSimple() {
final String originalContent = "Need to optimize the C001 temperature.\n" +
"C010 needs to be changed as it is damaged.\tC100 seems ok.";
final String expectedContent = "Need to optimize the tyre temperature.\n" +
"front wing needs to be changed as it is damaged.\tdamper seems ok.";
testWithContent(originalContent, expectedContent);
}
public void testEmptyField() {
final String originalContent = "";
final String expectedContent = "";
testWithContent(originalContent, expectedContent);
}
}