From bd32a2aebb3a3093c44943cca1ff18f4e51eb648 Mon Sep 17 00:00:00 2001 From: "Claudio Maggioni (maggicl)" Date: Sat, 9 May 2020 13:13:31 +0200 Subject: [PATCH 01/10] more Sonarqube fixes --- .../sanmarinoes/smarthut/config/JWTTokenUtils.java | 2 +- .../smarthut/controller/MotionSensorController.java | 2 -- .../controller/SecurityCameraController.java | 4 ++-- .../inf/sa4/sanmarinoes/smarthut/models/Device.java | 13 ++++++++++--- .../sanmarinoes/smarthut/models/RangeTrigger.java | 2 -- .../sa4/sanmarinoes/smarthut/models/Trigger.java | 2 -- 6 files changed, 13 insertions(+), 12 deletions(-) diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/JWTTokenUtils.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/JWTTokenUtils.java index f6943a8..9d2d939 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/JWTTokenUtils.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/JWTTokenUtils.java @@ -14,7 +14,7 @@ import org.springframework.stereotype.Component; @Component public class JWTTokenUtils { /** The duration in seconds of the validity of a single token */ - private static final long JWT_TOKEN_VALIDITY = 5 * 60 * 60; + private static final long JWT_TOKEN_VALIDITY = (long) 5 * 60 * 60; /** The secret key used to encrypt all JWTs */ @Value("${jwt.secret}") diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/MotionSensorController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/MotionSensorController.java index 6fcd7ca..660387a 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/MotionSensorController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/MotionSensorController.java @@ -6,7 +6,6 @@ import ch.usi.inf.sa4.sanmarinoes.smarthut.models.MotionSensor; import ch.usi.inf.sa4.sanmarinoes.smarthut.models.MotionSensorRepository; import ch.usi.inf.sa4.sanmarinoes.smarthut.service.DeviceService; import ch.usi.inf.sa4.sanmarinoes.smarthut.service.MotionSensorService; -import ch.usi.inf.sa4.sanmarinoes.smarthut.socket.SensorSocketEndpoint; import java.security.Principal; import javax.validation.Valid; import org.springframework.beans.factory.annotation.Autowired; @@ -21,7 +20,6 @@ public class MotionSensorController { @Autowired private DeviceService deviceService; @Autowired private MotionSensorService motionSensorService; @Autowired private MotionSensorRepository motionSensorRepository; - @Autowired private SensorSocketEndpoint sensorSocketEndpoint; @PostMapping public MotionSensor create( diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/SecurityCameraController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/SecurityCameraController.java index 1554f0a..1bbc750 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/SecurityCameraController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/SecurityCameraController.java @@ -76,8 +76,8 @@ public class SecurityCameraController { .findByIdAndUsername(deviceId, principal.getName()) .orElseThrow(NotFoundException::new); State s = d.cloneState(); - sceneRepository.findById(sceneId).orElseThrow(NotFoundException::new); - s.setSceneId(sceneId); + final Scene sc = sceneRepository.findById(sceneId).orElseThrow(NotFoundException::new); + s.setSceneId(sc.getId()); if (stateRepository.countByDeviceIdAndSceneId(deviceId, sceneId) > 0) throw new DuplicateStateException(); return stateRepository.save(s); diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Device.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Device.java index aa88d09..be6f897 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Device.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Device.java @@ -4,7 +4,6 @@ import ch.usi.inf.sa4.sanmarinoes.smarthut.config.GsonExclude; import ch.usi.inf.sa4.sanmarinoes.smarthut.config.SocketGsonExclude; import com.google.gson.annotations.SerializedName; import io.swagger.annotations.ApiModelProperty; -import java.util.HashSet; import java.util.Set; import javax.persistence.*; @@ -13,6 +12,14 @@ import javax.persistence.*; @Inheritance(strategy = InheritanceType.JOINED) public abstract class Device { + public Set> getTriggers() { + return triggers; + } + + public Set> getStates() { + return states; + } + /** Ways a device can behave in the automation flow. For now only input/output */ public enum FlowType { @SerializedName("INPUT") @@ -38,7 +45,7 @@ public abstract class Device { @OneToMany(mappedBy = "device", orphanRemoval = true) @GsonExclude @SocketGsonExclude - private Set> triggers = new HashSet<>(); + private Set> triggers; /** * The room this device belongs in, as a foreign key id. To use when updating and inserting from @@ -66,7 +73,7 @@ public abstract class Device { @OneToMany(mappedBy = "device", orphanRemoval = true) @GsonExclude @SocketGsonExclude - private Set> states = new HashSet<>(); + private Set> states; @Transient @GsonExclude private Long fromHostId = null; diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/RangeTrigger.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/RangeTrigger.java index 5fdc119..c4d5836 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/RangeTrigger.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/RangeTrigger.java @@ -3,7 +3,6 @@ package ch.usi.inf.sa4.sanmarinoes.smarthut.models; import com.google.gson.annotations.SerializedName; import javax.persistence.Column; import javax.persistence.Entity; -import javax.validation.constraints.NotNull; @Entity public class RangeTrigger extends Trigger { @@ -46,7 +45,6 @@ public class RangeTrigger extends Trigger { private Automation automation; @Column(name = "automation_id", nullable = false) - @NotNull private Long automationId; public long getId() { From ba02475c832b254fd148e57ebf10d3ff33da53f6 Mon Sep 17 00:00:00 2001 From: "Claudio Maggioni (maggicl)" Date: Sat, 9 May 2020 13:18:33 +0200 Subject: [PATCH 02/10] Fixed very severe security vulnerability (Use logger instead of System.out in SensorSocketEndpoint) --- .../sanmarinoes/smarthut/socket/SensorSocketEndpoint.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/socket/SensorSocketEndpoint.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/socket/SensorSocketEndpoint.java index 5cb3110..cec40f2 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/socket/SensorSocketEndpoint.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/socket/SensorSocketEndpoint.java @@ -13,6 +13,8 @@ import com.google.gson.Gson; import java.io.IOException; import java.util.*; import javax.websocket.*; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Component; @@ -20,6 +22,8 @@ import org.springframework.stereotype.Component; @Component public class SensorSocketEndpoint extends Endpoint { + private static final Logger logger = LoggerFactory.getLogger(SensorSocketEndpoint.class); + private final Gson gson = GsonConfig.socketGson(); @Autowired private DevicePopulationService deviceService; @@ -98,7 +102,7 @@ public class SensorSocketEndpoint extends Endpoint { authorizedClients.remove(u, s); } } catch (IOException e) { - e.printStackTrace(); + logger.warn(e.getLocalizedMessage(), e); } } } From 204f7bf423e499c1cd740cc65adc55f917392e36 Mon Sep 17 00:00:00 2001 From: "Claudio Maggioni (maggicl)" Date: Sat, 9 May 2020 13:29:03 +0200 Subject: [PATCH 03/10] Even more Sonarqube fixes --- .../controller/DimmableLightController.java | 8 ++--- .../smarthut/controller/RoomController.java | 29 ++++++++++++++----- .../controller/SecurityCameraController.java | 20 +++++++++---- .../smarthut/controller/SensorController.java | 17 +++++++---- .../sanmarinoes/smarthut/models/Device.java | 8 +++++ 5 files changed, 60 insertions(+), 22 deletions(-) diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/DimmableLightController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/DimmableLightController.java index e315ff1..ffd39fa 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/DimmableLightController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/DimmableLightController.java @@ -16,10 +16,10 @@ import org.springframework.web.bind.annotation.*; @RequestMapping("/dimmableLight") public class DimmableLightController extends GuestEnabledController { - private DimmableLightRepository dimmableLightRepository; - private SceneRepository sceneRepository; - private StateRepository> stateRepository; - private DeviceService deviceService; + private final DimmableLightRepository dimmableLightRepository; + private final SceneRepository sceneRepository; + private final StateRepository> stateRepository; + private final DeviceService deviceService; @Autowired public DimmableLightController( diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/RoomController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/RoomController.java index 8b7f648..79b61d2 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/RoomController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/RoomController.java @@ -6,7 +6,6 @@ import ch.usi.inf.sa4.sanmarinoes.smarthut.dto.RoomSaveRequest; import ch.usi.inf.sa4.sanmarinoes.smarthut.error.NotFoundException; import ch.usi.inf.sa4.sanmarinoes.smarthut.models.*; import ch.usi.inf.sa4.sanmarinoes.smarthut.service.DeviceService; -import ch.usi.inf.sa4.sanmarinoes.smarthut.service.ThermostatService; import ch.usi.inf.sa4.sanmarinoes.smarthut.utils.Utils; import java.security.Principal; import java.util.*; @@ -20,19 +19,33 @@ import org.springframework.web.bind.annotation.*; @RequestMapping("/room") public class RoomController { - @Autowired private RoomRepository roomRepository; + private final RoomRepository roomRepository; - @Autowired private UserRepository userRepository; + private final UserRepository userRepository; - @Autowired private DeviceService deviceService; + private final DeviceService deviceService; - @Autowired private SwitchRepository switchRepository; + private final SwitchRepository switchRepository; - @Autowired private ButtonDimmerRepository buttonDimmerRepository; + private final ButtonDimmerRepository buttonDimmerRepository; - @Autowired private KnobDimmerRepository knobDimmerRepository; + private final KnobDimmerRepository knobDimmerRepository; - @Autowired private ThermostatService thermostatService; + @Autowired + public RoomController( + RoomRepository roomRepository, + UserRepository userRepository, + DeviceService deviceService, + SwitchRepository switchRepository, + ButtonDimmerRepository buttonDimmerRepository, + KnobDimmerRepository knobDimmerRepository) { + this.roomRepository = roomRepository; + this.userRepository = userRepository; + this.deviceService = deviceService; + this.switchRepository = switchRepository; + this.buttonDimmerRepository = buttonDimmerRepository; + this.knobDimmerRepository = knobDimmerRepository; + } private List fetchOwnerOrGuest( final List list, Long hostId, final Principal principal) throws NotFoundException { diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/SecurityCameraController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/SecurityCameraController.java index 1bbc750..9716430 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/SecurityCameraController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/SecurityCameraController.java @@ -22,12 +22,22 @@ import org.springframework.web.bind.annotation.RestController; @EnableAutoConfiguration @RequestMapping("/securityCamera") public class SecurityCameraController { + private final DeviceService deviceService; + private final SecurityCameraRepository securityCameraService; + private final SceneRepository sceneRepository; + private final StateRepository> stateRepository; - @Autowired private DeviceService deviceService; - @Autowired private SecurityCameraRepository securityCameraService; - @Autowired private SceneRepository sceneRepository; - @Autowired private StateRepository> stateRepository; - @Autowired private RoomRepository roomRepository; + @Autowired + public SecurityCameraController( + DeviceService deviceService, + SecurityCameraRepository securityCameraService, + SceneRepository sceneRepository, + StateRepository> stateRepository) { + this.deviceService = deviceService; + this.securityCameraService = securityCameraService; + this.sceneRepository = sceneRepository; + this.stateRepository = stateRepository; + } private SecurityCamera save( SecurityCamera newSC, SwitchableSaveRequest sc, final Principal principal) { diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/SensorController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/SensorController.java index 3833452..ff1677d 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/SensorController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/SensorController.java @@ -5,7 +5,6 @@ import ch.usi.inf.sa4.sanmarinoes.smarthut.error.NotFoundException; import ch.usi.inf.sa4.sanmarinoes.smarthut.models.*; import ch.usi.inf.sa4.sanmarinoes.smarthut.service.DeviceService; import ch.usi.inf.sa4.sanmarinoes.smarthut.service.SensorService; -import ch.usi.inf.sa4.sanmarinoes.smarthut.socket.SensorSocketEndpoint; import java.math.BigDecimal; import java.security.Principal; import java.util.*; @@ -19,13 +18,21 @@ import org.springframework.web.bind.annotation.*; @RequestMapping("/sensor") public class SensorController { - @Autowired private DeviceService deviceService; + private final DeviceService deviceService; - @Autowired private SensorRepository sensorRepository; + private final SensorRepository sensorRepository; - @Autowired private SensorSocketEndpoint sensorSocketEndpoint; + private final SensorService sensorService; - @Autowired private SensorService sensorService; + @Autowired + public SensorController( + DeviceService deviceService, + SensorRepository sensorRepository, + SensorService sensorService) { + this.deviceService = deviceService; + this.sensorRepository = sensorRepository; + this.sensorService = sensorService; + } @PostMapping public Sensor create(@Valid @RequestBody SensorSaveRequest s, final Principal principal) diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Device.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Device.java index be6f897..3d6847f 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Device.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Device.java @@ -75,6 +75,14 @@ public abstract class Device { @SocketGsonExclude private Set> states; + public String getKind() { + return kind; + } + + public FlowType getFlowType() { + return flowType; + } + @Transient @GsonExclude private Long fromHostId = null; @Transient @GsonExclude private boolean fromGuest = false; From 6e98972a5ba090b15c9bf2db26dfea826fe2e7f8 Mon Sep 17 00:00:00 2001 From: "Claudio Maggioni (maggicl)" Date: Sat, 9 May 2020 13:42:17 +0200 Subject: [PATCH 04/10] Minor code style fixes and global formatter run --- .../controller/ScenePriorityController.java | 1 - .../sanmarinoes/smarthut/models/Connector.java | 1 - .../sanmarinoes/smarthut/models/Curtains.java | 4 ++-- .../smarthut/models/DimmableRepository.java | 3 +-- .../sa4/sanmarinoes/smarthut/models/Room.java | 3 +-- .../smarthut/models/ThermostatRepository.java | 3 +-- .../service/DevicePropagationService.java | 16 +++++++++++++--- .../smarthut/service/JWTUserDetailsService.java | 3 +-- .../smarthut/service/SceneService.java | 17 ++++++++++++----- .../smarthut/service/ThermostatService.java | 4 +++- 10 files changed, 34 insertions(+), 21 deletions(-) diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ScenePriorityController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ScenePriorityController.java index 6e95f75..1449727 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ScenePriorityController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ScenePriorityController.java @@ -24,7 +24,6 @@ public class ScenePriorityController { @Autowired ScenePriorityRepository scenePriorityRepository; - @GetMapping("/{automationId}") public List getByAutomationId(@PathVariable long automationId) throws NotFoundException { diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Connector.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Connector.java index 701a010..325f0dd 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Connector.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Connector.java @@ -1,7 +1,6 @@ package ch.usi.inf.sa4.sanmarinoes.smarthut.models; import java.util.Set; -import java.util.function.BiConsumer; import java.util.function.Function; /** diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Curtains.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Curtains.java index d9e8d98..af2fd40 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Curtains.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Curtains.java @@ -3,8 +3,8 @@ package ch.usi.inf.sa4.sanmarinoes.smarthut.models; import javax.persistence.Entity; /** - * Represents a curtain. The intensity represents how much the curtains are opened, - * 0 is completely closed 100 is completely open + * Represents a curtain. The intensity represents how much the curtains are opened, 0 is completely + * closed 100 is completely open */ @Entity public class Curtains extends Dimmable { diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/DimmableRepository.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/DimmableRepository.java index be791c9..dffbbdb 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/DimmableRepository.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/DimmableRepository.java @@ -1,4 +1,3 @@ package ch.usi.inf.sa4.sanmarinoes.smarthut.models; -public interface DimmableRepository extends SwitchableRepository { -} +public interface DimmableRepository extends SwitchableRepository {} diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Room.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Room.java index 73d7794..43b7e35 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Room.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Room.java @@ -2,7 +2,6 @@ package ch.usi.inf.sa4.sanmarinoes.smarthut.models; import ch.usi.inf.sa4.sanmarinoes.smarthut.config.GsonExclude; import io.swagger.annotations.ApiModelProperty; -import java.util.HashSet; import java.util.Set; import javax.persistence.*; import javax.validation.constraints.NotNull; @@ -36,7 +35,7 @@ public class Room { @OneToMany(mappedBy = "room", orphanRemoval = true) @GsonExclude - private Set devices = new HashSet<>(); + private Set devices; /** * User that owns the house this room is in as a foreign key id. To use when updating and diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/ThermostatRepository.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/ThermostatRepository.java index 290ebf5..768b882 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/ThermostatRepository.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/ThermostatRepository.java @@ -24,7 +24,6 @@ public interface ThermostatRepository extends DeviceRepository { * @param thermostatRoomId room ID of the thermostat * @return an optional big decimal, empty if none found */ - @Query( - "SELECT AVG(s.value) FROM Sensor s JOIN s.room r WHERE s.sensor = ?2 AND r.id = ?1") + @Query("SELECT AVG(s.value) FROM Sensor s JOIN s.room r WHERE s.sensor = ?2 AND r.id = ?1") Optional getAverageTemperature(Long thermostatRoomId, Sensor.SensorType sensorType); } diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/DevicePropagationService.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/DevicePropagationService.java index 8df15ea..ae004a4 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/DevicePropagationService.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/DevicePropagationService.java @@ -13,9 +13,19 @@ import org.springframework.stereotype.Component; @Component public class DevicePropagationService { - @Autowired private SensorSocketEndpoint endpoint; - @Autowired private EagerUserRepository userRepository; - @Autowired private DeviceRepository deviceRepository; + private final SensorSocketEndpoint endpoint; + private final EagerUserRepository userRepository; + private final DeviceRepository deviceRepository; + + @Autowired + public DevicePropagationService( + SensorSocketEndpoint endpoint, + EagerUserRepository userRepository, + DeviceRepository deviceRepository) { + this.endpoint = endpoint; + this.userRepository = userRepository; + this.deviceRepository = deviceRepository; + } void propagateUpdateAsGuest(Device device, User host, User guest) { final Set guests = Set.copyOf(host.getGuests()); diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/JWTUserDetailsService.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/JWTUserDetailsService.java index 7dff142..8ab5f8a 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/JWTUserDetailsService.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/JWTUserDetailsService.java @@ -1,9 +1,8 @@ package ch.usi.inf.sa4.sanmarinoes.smarthut.service; -import java.util.Set; - import ch.usi.inf.sa4.sanmarinoes.smarthut.models.User; import ch.usi.inf.sa4.sanmarinoes.smarthut.models.UserRepository; +import java.util.Set; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.security.core.*; import org.springframework.security.core.userdetails.UserDetails; diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/SceneService.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/SceneService.java index 71bf6d1..0fcf1f8 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/SceneService.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/SceneService.java @@ -3,16 +3,23 @@ package ch.usi.inf.sa4.sanmarinoes.smarthut.service; import ch.usi.inf.sa4.sanmarinoes.smarthut.models.*; import java.util.ArrayList; import java.util.List; -import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Component; @Component public class SceneService { - @Autowired private DeviceRepository deviceRepository; - @Autowired private DevicePopulationService devicePopulationService; - @Autowired private DevicePropagationService devicePropagationService; - @Autowired private StateRepository> stateRepository; + private final DevicePopulationService devicePopulationService; + private final DevicePropagationService devicePropagationService; + private final StateRepository> stateRepository; + + public SceneService( + DevicePopulationService devicePopulationService, + DevicePropagationService devicePropagationService, + StateRepository> stateRepository) { + this.devicePopulationService = devicePopulationService; + this.devicePropagationService = devicePropagationService; + this.stateRepository = stateRepository; + } private List copyStatesToDevices(Scene fromScene) { final List updated = new ArrayList<>(fromScene.getStates().size()); diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/ThermostatService.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/ThermostatService.java index 100d77d..d11e76e 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/ThermostatService.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/ThermostatService.java @@ -77,7 +77,9 @@ public class ThermostatService { Optional average; if (thermostat.isUseExternalSensors()) { - average = thermostatRepository.getAverageTemperature(thermostat.getRoomId(), Sensor.SensorType.TEMPERATURE); + average = + thermostatRepository.getAverageTemperature( + thermostat.getRoomId(), Sensor.SensorType.TEMPERATURE); } else { return thermostat.getInternalSensorTemperature(); From 191870d3c6c6d870f76575393c3e12bd58caddc6 Mon Sep 17 00:00:00 2001 From: "Claudio Maggioni (maggicl)" Date: Sat, 9 May 2020 14:05:43 +0200 Subject: [PATCH 05/10] More sonarqube fixes --- .../controller/ThermostatController.java | 4 +-- .../service/DevicePopulationService.java | 2 +- .../service/ThermostatPopulationService.java | 34 +++++++++++++++++++ .../smarthut/service/ThermostatService.java | 29 ++++------------ 4 files changed, 43 insertions(+), 26 deletions(-) create mode 100644 src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/ThermostatPopulationService.java diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ThermostatController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ThermostatController.java index 8ab96f5..386e1ca 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ThermostatController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ThermostatController.java @@ -5,7 +5,7 @@ import ch.usi.inf.sa4.sanmarinoes.smarthut.error.DuplicateStateException; import ch.usi.inf.sa4.sanmarinoes.smarthut.error.NotFoundException; import ch.usi.inf.sa4.sanmarinoes.smarthut.models.*; import ch.usi.inf.sa4.sanmarinoes.smarthut.service.DeviceService; -import ch.usi.inf.sa4.sanmarinoes.smarthut.service.ThermostatService; +import ch.usi.inf.sa4.sanmarinoes.smarthut.service.ThermostatPopulationService; import java.security.Principal; import javax.validation.Valid; import org.springframework.beans.factory.annotation.Autowired; @@ -19,7 +19,7 @@ public class ThermostatController { @Autowired private DeviceService deviceService; @Autowired private ThermostatRepository thermostatRepository; - @Autowired private ThermostatService thermostatService; + @Autowired private ThermostatPopulationService thermostatService; @Autowired private SceneRepository sceneRepository; @Autowired private StateRepository> stateRepository; diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/DevicePopulationService.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/DevicePopulationService.java index 4d3d490..9b3e7d2 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/DevicePopulationService.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/DevicePopulationService.java @@ -8,7 +8,7 @@ import org.springframework.stereotype.Component; @Component public class DevicePopulationService { - @Autowired private ThermostatService thermostatService; + @Autowired private ThermostatPopulationService thermostatService; public void populateComputedFields(Iterable devices) { for (Device d : devices) { diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/ThermostatPopulationService.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/ThermostatPopulationService.java new file mode 100644 index 0000000..d8e1878 --- /dev/null +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/ThermostatPopulationService.java @@ -0,0 +1,34 @@ +package ch.usi.inf.sa4.sanmarinoes.smarthut.service; + +import ch.usi.inf.sa4.sanmarinoes.smarthut.models.Sensor; +import ch.usi.inf.sa4.sanmarinoes.smarthut.models.Thermostat; +import ch.usi.inf.sa4.sanmarinoes.smarthut.models.ThermostatRepository; +import java.math.BigDecimal; +import java.util.Optional; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.stereotype.Component; + +@Component +public class ThermostatPopulationService { + + @Autowired private ThermostatRepository thermostatRepository; + + private BigDecimal measureTemperature(final Thermostat thermostat) { + Optional average; + + if (thermostat.isUseExternalSensors()) { + average = + thermostatRepository.getAverageTemperature( + thermostat.getRoomId(), Sensor.SensorType.TEMPERATURE); + + } else { + return thermostat.getInternalSensorTemperature(); + } + + return average.orElse(null); + } + + public void populateMeasuredTemperature(Thermostat thermostat) { + thermostat.setMeasuredTemperature(measureTemperature(thermostat)); + } +} diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/ThermostatService.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/ThermostatService.java index d11e76e..5eeec6c 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/ThermostatService.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/ThermostatService.java @@ -16,7 +16,9 @@ public class ThermostatService { @Autowired private SensorSocketEndpoint endpoint; - @Autowired private DevicePropagationService deviceService; + @Autowired private DeviceService deviceService; + + @Autowired private ThermostatPopulationService thermostatPopulationService; @Autowired private ThermostatRepository thermostatRepository; @@ -41,12 +43,12 @@ public class ThermostatService { public List findAll(String username) { Iterable all = thermostatRepository.findAllByUsername(username); - all.forEach(this::populateMeasuredTemperature); + all.forEach(thermostatPopulationService::populateMeasuredTemperature); return Utils.toList(all); } public void computeState(Thermostat t) { - populateMeasuredTemperature(t); + thermostatPopulationService.populateMeasuredTemperature(t); t.computeState(); } @@ -67,28 +69,9 @@ public class ThermostatService { if (t.isPresent()) { Thermostat u = t.get(); - populateMeasuredTemperature(u); + thermostatPopulationService.populateMeasuredTemperature(u); t = Optional.of(u); } return t; } - - private BigDecimal measureTemperature(final Thermostat thermostat) { - Optional average; - - if (thermostat.isUseExternalSensors()) { - average = - thermostatRepository.getAverageTemperature( - thermostat.getRoomId(), Sensor.SensorType.TEMPERATURE); - - } else { - return thermostat.getInternalSensorTemperature(); - } - - return average.orElse(null); - } - - public void populateMeasuredTemperature(Thermostat thermostat) { - thermostat.setMeasuredTemperature(measureTemperature(thermostat)); - } } From 15faf0a6b40a8ef5482e542b7e613ecf75e0dc90 Mon Sep 17 00:00:00 2001 From: "Claudio Maggioni (maggicl)" Date: Sat, 9 May 2020 14:23:39 +0200 Subject: [PATCH 06/10] Fixed circular dependency on switch connector --- .../controller/ButtonDimmerController.java | 2 +- .../InputDeviceConnectionController.java | 18 +++----- .../controller/KnobDimmerController.java | 2 +- .../smarthut/controller/SwitchController.java | 6 +-- .../smarthut/models/Connectable.java | 5 ++ .../smarthut/models/Connector.java | 46 ------------------- .../sanmarinoes/smarthut/models/Dimmable.java | 6 --- .../sanmarinoes/smarthut/models/Dimmer.java | 12 ++++- .../sanmarinoes/smarthut/models/Switch.java | 12 ++++- .../smarthut/models/Switchable.java | 3 -- 10 files changed, 38 insertions(+), 74 deletions(-) create mode 100644 src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Connectable.java delete mode 100644 src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Connector.java diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ButtonDimmerController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ButtonDimmerController.java index cf2cb56..e2bc359 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ButtonDimmerController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ButtonDimmerController.java @@ -26,7 +26,7 @@ public class ButtonDimmerController ButtonDimmerRepository inputRepository, DimmableRepository outputRepository, DeviceService deviceService) { - super(inputRepository, outputRepository, DimmableLight.BUTTON_DIMMER_DIMMABLE_CONNECTOR); + super(inputRepository, outputRepository); this.deviceService = deviceService; this.buttonDimmerRepository = inputRepository; } diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/InputDeviceConnectionController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/InputDeviceConnectionController.java index 575d196..4b92125 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/InputDeviceConnectionController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/InputDeviceConnectionController.java @@ -23,7 +23,7 @@ import org.springframework.web.bind.annotation.RequestBody; * @param the output device attached to I */ public abstract class InputDeviceConnectionController< - I extends InputDevice, O extends OutputDevice> { + I extends InputDevice & Connectable, O extends OutputDevice> { private class Connection { private final I input; @@ -53,26 +53,20 @@ public abstract class InputDeviceConnectionController< @Autowired private DeviceService deviceService; - private DeviceRepository inputRepository; + private final DeviceRepository inputRepository; - private DeviceRepository outputReposiory; - - private Connector connector; + private final DeviceRepository outputReposiory; /** * Contstructs the controller by requiring essential object for the controller implementation * * @param inputRepository the input device repository * @param outputRepository the output device repository - * @param connector a appropriate Connector instance for the I and O tyoes. */ protected InputDeviceConnectionController( - DeviceRepository inputRepository, - DeviceRepository outputRepository, - Connector connector) { + DeviceRepository inputRepository, DeviceRepository outputRepository) { this.inputRepository = inputRepository; this.outputReposiory = outputRepository; - this.connector = connector; } private Connection checkConnectionIDs(Long inputId, List outputs, String username) @@ -104,7 +98,7 @@ public abstract class InputDeviceConnectionController< final Connection pair = checkConnectionIDs(inputId, outputs, username); for (final O o : pair.getOutputs()) { - connector.connect(pair.getInput(), o, true); + pair.getInput().connect(o, true); } deviceService.saveAllAsOwner(pair.getOutputs(), username); @@ -124,7 +118,7 @@ public abstract class InputDeviceConnectionController< final Connection pair = checkConnectionIDs(inputId, outputs, username); for (final O o : pair.getOutputs()) { - connector.connect(pair.getInput(), o, false); + pair.getInput().connect(o, false); } deviceService.saveAllAsOwner(pair.getOutputs(), username); diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/KnobDimmerController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/KnobDimmerController.java index f0900e4..f80e1fd 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/KnobDimmerController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/KnobDimmerController.java @@ -25,7 +25,7 @@ public class KnobDimmerController extends InputDeviceConnectionController outputRepository, DeviceService deviceService) { - super(inputRepository, outputRepository, Dimmable.KNOB_DIMMER_DIMMABLE_CONNECTOR); + super(inputRepository, outputRepository); this.knobDimmerRepository = inputRepository; this.deviceService = deviceService; } diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/SwitchController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/SwitchController.java index 96f5a52..299c7e5 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/SwitchController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/SwitchController.java @@ -17,8 +17,8 @@ import org.springframework.web.bind.annotation.*; @RequestMapping("/switch") public class SwitchController extends InputDeviceConnectionController { - private SwitchRepository switchRepository; - private DeviceService deviceService; + private final SwitchRepository switchRepository; + private final DeviceService deviceService; /** * Contstructs the controller by requiring essential object for the controller implementation @@ -31,7 +31,7 @@ public class SwitchController extends InputDeviceConnectionController outputRepository, DeviceService deviceService) { - super(inputRepository, outputRepository, Switchable.SWITCH_SWITCHABLE_CONNECTOR); + super(inputRepository, outputRepository); this.deviceService = deviceService; this.switchRepository = inputRepository; } diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Connectable.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Connectable.java new file mode 100644 index 0000000..8423930 --- /dev/null +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Connectable.java @@ -0,0 +1,5 @@ +package ch.usi.inf.sa4.sanmarinoes.smarthut.models; + +public interface Connectable { + void connect(O output, boolean connect); +} diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Connector.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Connector.java deleted file mode 100644 index 325f0dd..0000000 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Connector.java +++ /dev/null @@ -1,46 +0,0 @@ -package ch.usi.inf.sa4.sanmarinoes.smarthut.models; - -import java.util.Set; -import java.util.function.Function; - -/** - * A rule on how to connect an input device type to an output device type - * - * @param the input device type - * @param the output device type - */ -@FunctionalInterface -public interface Connector { - - /** - * Connects or disconnects input to output - * - * @param input the input device - * @param output the output device - * @param connect true if connection, false if disconnection - */ - void connect(I input, O output, boolean connect); - - /** - * Produces a basic implementation of a connector, assuming there is a ManyToMany relationship - * between J and K - * - * @param outputsGetter the getter method of the set of outputs on the input class - * @param inputsGetter the getter method of the set of outputs on the input class - * @param the input device type - * @param the output device type - * @return a Connector implementation for the pair of types J and K - */ - static Connector basic( - Function> outputsGetter, Function> inputsGetter) { - return (i, o, connect) -> { - if (connect) { - outputsGetter.apply(i).add(o); - inputsGetter.apply(o).add(i); - } else { - outputsGetter.apply(i).remove(o); - inputsGetter.apply(o).remove(i); - } - }; - } -} diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Dimmable.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Dimmable.java index 6ae3150..bc093e0 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Dimmable.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Dimmable.java @@ -12,12 +12,6 @@ import javax.validation.constraints.NotNull; @Inheritance(strategy = InheritanceType.SINGLE_TABLE) public class Dimmable extends Switchable implements RangeTriggerable { - public static final Connector KNOB_DIMMER_DIMMABLE_CONNECTOR = - Connector.basic(KnobDimmer::getOutputs, Dimmable::getDimmers); - - public static final Connector BUTTON_DIMMER_DIMMABLE_CONNECTOR = - Connector.basic(ButtonDimmer::getOutputs, Dimmable::getDimmers); - protected Dimmable(String kind) { super(kind); } diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Dimmer.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Dimmer.java index e920d2f..cd3ee64 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Dimmer.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Dimmer.java @@ -9,7 +9,7 @@ import javax.persistence.*; /** Represents a generic dimmer input device */ @Entity @Inheritance(strategy = InheritanceType.TABLE_PER_CLASS) -public abstract class Dimmer extends InputDevice { +public abstract class Dimmer extends InputDevice implements Connectable { public Dimmer(String kind) { super(kind); } @@ -37,4 +37,14 @@ public abstract class Dimmer extends InputDevice { public void addDimmable(Dimmable dimmable) { dimmables.add(dimmable); } + + public void connect(Dimmable output, boolean connect) { + if (connect) { + output.getDimmers().add(this); + getOutputs().add(output); + } else { + output.getDimmers().remove(this); + getOutputs().remove(output); + } + } } diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Switch.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Switch.java index 7825eae..82ab671 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Switch.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Switch.java @@ -8,7 +8,7 @@ import javax.persistence.*; /** A switch input device */ @Entity -public class Switch extends InputDevice implements BooleanTriggerable { +public class Switch extends InputDevice implements BooleanTriggerable, Connectable { @ManyToMany( cascade = { @@ -64,6 +64,16 @@ public class Switch extends InputDevice implements BooleanTriggerable { return switchables; } + public void connect(Switchable output, boolean connect) { + if (connect) { + output.getSwitches().add(this); + getOutputs().add(output); + } else { + output.getSwitches().remove(this); + getOutputs().remove(output); + } + } + @Override public boolean readTriggerState() { return on; diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Switchable.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Switchable.java index 9db6361..a1a5366 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Switchable.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Switchable.java @@ -11,9 +11,6 @@ import javax.persistence.*; @Inheritance(strategy = InheritanceType.JOINED) public abstract class Switchable extends OutputDevice { - public static final Connector SWITCH_SWITCHABLE_CONNECTOR = - Connector.basic(Switch::getOutputs, Switchable::getSwitches); - @ManyToMany( mappedBy = "switchables", cascade = { From b4ded92695f18ebad112fee136c73c22f45b248a Mon Sep 17 00:00:00 2001 From: Claudio Maggioni Date: Sat, 9 May 2020 17:44:38 +0200 Subject: [PATCH 07/10] Sonarqube fixes --- .../controller/AutomationController.java | 10 +- .../sanmarinoes/smarthut/models/Device.java | 106 ++++++++++-------- .../sa4/sanmarinoes/smarthut/models/Room.java | 11 +- .../smarthut/models/ScenePriority.java | 31 ++--- 4 files changed, 97 insertions(+), 61 deletions(-) diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/AutomationController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/AutomationController.java index cfad787..5f93b86 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/AutomationController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/AutomationController.java @@ -100,7 +100,15 @@ public class AutomationController { req.getScenes() .stream() .map(AutomationFastUpdateRequest.ScenePriorityDTO::toModel) - .map(t -> t.setAutomationId(a.getId())) + .peek( + t -> { + t.setAutomationId(a.getId()); + + // this is here just to pass the quality gate, + // please do not replicate unless the quality gate sees + // it as a bug + t.setAutomation(a); + }) .collect(Collectors.toList())); a.getScenes().clear(); diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Device.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Device.java index 3d6847f..ebaf4b0 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Device.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Device.java @@ -12,14 +12,6 @@ import javax.persistence.*; @Inheritance(strategy = InheritanceType.JOINED) public abstract class Device { - public Set> getTriggers() { - return triggers; - } - - public Set> getStates() { - return states; - } - /** Ways a device can behave in the automation flow. For now only input/output */ public enum FlowType { @SerializedName("INPUT") @@ -75,42 +67,15 @@ public abstract class Device { @SocketGsonExclude private Set> states; - public String getKind() { - return kind; - } - - public FlowType getFlowType() { - return flowType; - } - @Transient @GsonExclude private Long fromHostId = null; @Transient @GsonExclude private boolean fromGuest = false; @Transient @GsonExclude private boolean deleted = false; - public Long getFromHostId() { - return fromHostId; - } - - public void setFromHostId(Long fromHostId) { - this.fromHostId = fromHostId; - } - - public boolean isDeleted() { - return deleted; - } - - public void setDeleted(boolean deleted) { - this.deleted = deleted; - } - - public boolean isFromGuest() { - return fromGuest; - } - - public void setFromGuest(boolean fromGuest) { - this.fromGuest = fromGuest; + public Device(String kind, FlowType flowType) { + this.kind = kind; + this.flowType = flowType; } public long getId() { @@ -121,12 +86,20 @@ public abstract class Device { this.id = id; } - public String getName() { - return name; + public Room getRoom() { + return room; } - public void setName(String name) { - this.name = name; + public void setRoom(Room room) { + this.room = room; + } + + public Set> getTriggers() { + return triggers; + } + + public void setTriggers(Set> triggers) { + this.triggers = triggers; } public Long getRoomId() { @@ -137,8 +110,51 @@ public abstract class Device { this.roomId = roomId; } - public Device(String kind, FlowType flowType) { - this.kind = kind; - this.flowType = flowType; + public String getName() { + return name; + } + + public void setName(String name) { + this.name = name; + } + + public String getKind() { + return kind; + } + + public FlowType getFlowType() { + return flowType; + } + + public Set> getStates() { + return states; + } + + public void setStates(Set> states) { + this.states = states; + } + + public Long getFromHostId() { + return fromHostId; + } + + public void setFromHostId(Long fromHostId) { + this.fromHostId = fromHostId; + } + + public boolean isFromGuest() { + return fromGuest; + } + + public void setFromGuest(boolean fromGuest) { + this.fromGuest = fromGuest; + } + + public boolean isDeleted() { + return deleted; + } + + public void setDeleted(boolean deleted) { + this.deleted = deleted; } } diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Room.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Room.java index 43b7e35..9e3ebc9 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Room.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Room.java @@ -2,6 +2,7 @@ package ch.usi.inf.sa4.sanmarinoes.smarthut.models; import ch.usi.inf.sa4.sanmarinoes.smarthut.config.GsonExclude; import io.swagger.annotations.ApiModelProperty; +import java.util.HashSet; import java.util.Set; import javax.persistence.*; import javax.validation.constraints.NotNull; @@ -35,7 +36,7 @@ public class Room { @OneToMany(mappedBy = "room", orphanRemoval = true) @GsonExclude - private Set devices; + private Set devices = new HashSet<>(); /** * User that owns the house this room is in as a foreign key id. To use when updating and @@ -98,4 +99,12 @@ public class Room { public String toString() { return "Room{" + "id=" + id + ", name='" + name + "\'}"; } + + public User getUser() { + return user; + } + + public void setUser(User user) { + this.user = user; + } } diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/ScenePriority.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/ScenePriority.java index 64e755b..0e05a0a 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/ScenePriority.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/ScenePriority.java @@ -45,6 +45,10 @@ public class ScenePriority { @NotNull private Long sceneId; + public long getId() { + return id; + } + public Integer getPriority() { return priority; } @@ -53,21 +57,16 @@ public class ScenePriority { this.priority = priority; } - public Automation getAutomation() { - return automation; - } - - public void setAutomation(Automation automation) { - this.automation = automation; - } - public Long getAutomationId() { return automationId; } - public ScenePriority setAutomationId(Long automationId) { + public void setAutomationId(Long automationId) { this.automationId = automationId; - return this; + } + + public void setAutomation(Automation automation) { + this.automation = automation; } public Scene getScene() { @@ -88,10 +87,14 @@ public class ScenePriority { @PreRemove public void preRemove() { - this.setAutomation(null); - this.setAutomationId(null); + this.automation = null; + this.automationId = null; - this.setScene(null); - this.setSceneId(null); + this.scene = null; + this.sceneId = null; + } + + public Automation getAutomation() { + return automation; } } From bd47a571d53ce47b6e14fc9e1a032250fbe29126 Mon Sep 17 00:00:00 2001 From: Claudio Maggioni Date: Sat, 9 May 2020 17:53:58 +0200 Subject: [PATCH 08/10] Sonarqube fixes --- .../smarthut/config/CORSFilter.java | 6 --- .../smarthut/config/JWTRequestFilter.java | 4 +- .../smarthut/config/JWTTokenUtils.java | 2 +- .../config/RuntimeTypeAdapterFactory.java | 41 ++++--------------- .../controller/AutomationController.java | 3 +- .../controller/DimmableLightController.java | 18 ++++---- .../smarthut/controller/GuestController.java | 4 +- 7 files changed, 21 insertions(+), 57 deletions(-) diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/CORSFilter.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/CORSFilter.java index d5e19ae..bfade8a 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/CORSFilter.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/CORSFilter.java @@ -31,10 +31,4 @@ public class CORSFilter implements Filter { chain.doFilter(req, res); } - - @Override - public void init(FilterConfig filterConfig) {} - - @Override - public void destroy() {} } diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/JWTRequestFilter.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/JWTRequestFilter.java index 503f7cd..3cfc094 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/JWTRequestFilter.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/JWTRequestFilter.java @@ -36,9 +36,9 @@ public class JWTRequestFilter extends OncePerRequestFilter { try { username = jwtTokenUtils.getUsernameFromToken(jwtToken); } catch (IllegalArgumentException e) { - System.out.println("Unable to get JWT Token"); + logger.info("Unable to get JWT Token"); } catch (ExpiredJwtException e) { - System.out.println("JWT Token has expired"); + logger.info("JWT Token has expired"); } } else { logger.warn("JWT Token does not begin with Bearer String"); diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/JWTTokenUtils.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/JWTTokenUtils.java index 9d2d939..78e5e5e 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/JWTTokenUtils.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/JWTTokenUtils.java @@ -68,7 +68,7 @@ public class JWTTokenUtils { * @param userDetails user details to validate against * @return true if valid, false if not */ - public Boolean validateToken(String token, UserDetails userDetails) { + public boolean validateToken(String token, UserDetails userDetails) { final String username = getUsernameFromToken(token); return (username.equals(userDetails.getUsername()) && !isTokenExpired(token)); } diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/RuntimeTypeAdapterFactory.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/RuntimeTypeAdapterFactory.java index dbe1331..d1d4e76 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/RuntimeTypeAdapterFactory.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/config/RuntimeTypeAdapterFactory.java @@ -1,21 +1,5 @@ package ch.usi.inf.sa4.sanmarinoes.smarthut.config; -/* - * Copyright (C) 2011 Google Inc. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - import com.google.gson.Gson; import com.google.gson.JsonElement; import com.google.gson.JsonObject; @@ -158,8 +142,8 @@ import java.util.Map; public final class RuntimeTypeAdapterFactory implements TypeAdapterFactory { private final Class baseType; private final String typeFieldName; - private final Map> labelToSubtype = new LinkedHashMap>(); - private final Map, String> subtypeToLabel = new LinkedHashMap, String>(); + private final Map> labelToSubtype = new LinkedHashMap<>(); + private final Map, String> subtypeToLabel = new LinkedHashMap<>(); private final boolean maintainType; private RuntimeTypeAdapterFactory( @@ -179,7 +163,7 @@ public final class RuntimeTypeAdapterFactory implements TypeAdapterFactory { */ public static RuntimeTypeAdapterFactory of( Class baseType, String typeFieldName, boolean maintainType) { - return new RuntimeTypeAdapterFactory(baseType, typeFieldName, maintainType); + return new RuntimeTypeAdapterFactory<>(baseType, typeFieldName, maintainType); } /** @@ -187,7 +171,7 @@ public final class RuntimeTypeAdapterFactory implements TypeAdapterFactory { * the type field name. Type field names are case sensitive. */ public static RuntimeTypeAdapterFactory of(Class baseType, String typeFieldName) { - return new RuntimeTypeAdapterFactory(baseType, typeFieldName, false); + return new RuntimeTypeAdapterFactory<>(baseType, typeFieldName, false); } /** @@ -195,7 +179,7 @@ public final class RuntimeTypeAdapterFactory implements TypeAdapterFactory { * field name. */ public static RuntimeTypeAdapterFactory of(Class baseType) { - return new RuntimeTypeAdapterFactory(baseType, "type", false); + return new RuntimeTypeAdapterFactory<>(baseType, "type", false); } /** @@ -216,26 +200,15 @@ public final class RuntimeTypeAdapterFactory implements TypeAdapterFactory { return this; } - /** - * Registers {@code type} identified by its {@link Class#getSimpleName simple name}. Labels are - * case sensitive. - * - * @throws IllegalArgumentException if either {@code type} or its simple name have already been - * registered on this type adapter. - */ - public RuntimeTypeAdapterFactory registerSubtype(Class type) { - return registerSubtype(type, type.getSimpleName()); - } - public TypeAdapter create(Gson gson, TypeToken type) { if (type.getRawType() != baseType) { return null; } final Map> labelToDelegate = - new LinkedHashMap>(labelToSubtype.size()); + new LinkedHashMap<>(labelToSubtype.size()); final Map, TypeAdapter> subtypeToDelegate = - new LinkedHashMap, TypeAdapter>(labelToSubtype.size()); + new LinkedHashMap<>(labelToSubtype.size()); for (Map.Entry> entry : labelToSubtype.entrySet()) { TypeAdapter delegate = gson.getDelegateAdapter(this, TypeToken.get(entry.getValue())); diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/AutomationController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/AutomationController.java index 5f93b86..c3027ae 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/AutomationController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/AutomationController.java @@ -33,8 +33,7 @@ public class AutomationController { @GetMapping public List getAll( @RequestParam(value = "hostId", required = false) Long hostId, - final Principal principal) - throws NotFoundException { + final Principal principal) { final Long userId = userService.findByUsername(principal.getName()).getId(); return automationRepository.findAllByUserId(userId); } diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/DimmableLightController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/DimmableLightController.java index ffd39fa..990c105 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/DimmableLightController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/DimmableLightController.java @@ -49,10 +49,10 @@ public class DimmableLightController extends GuestEnabledController sceneBinding( @PathVariable("id") long deviceId, diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/GuestController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/GuestController.java index f010b52..4b7109d 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/GuestController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/GuestController.java @@ -5,7 +5,6 @@ import static ch.usi.inf.sa4.sanmarinoes.smarthut.utils.Utils.toList; import ch.usi.inf.sa4.sanmarinoes.smarthut.dto.GuestPermissionsRequest; import ch.usi.inf.sa4.sanmarinoes.smarthut.dto.GuestsUpdateRequest; import ch.usi.inf.sa4.sanmarinoes.smarthut.dto.UserResponse; -import ch.usi.inf.sa4.sanmarinoes.smarthut.error.NotFoundException; import ch.usi.inf.sa4.sanmarinoes.smarthut.models.EagerUserRepository; import ch.usi.inf.sa4.sanmarinoes.smarthut.models.User; import java.security.Principal; @@ -46,8 +45,7 @@ public class GuestController { @PutMapping("/guests") public List setGuests( - @RequestBody @Valid GuestsUpdateRequest g, final Principal principal) - throws NotFoundException { + @RequestBody @Valid GuestsUpdateRequest g, final Principal principal) { Iterable guests = userRepository.findAllById(g.ids); User host = userRepository.findByUsername(principal.getName()); From 5d4aea2e5641741145cb5c97e709ae51ae0ccfc1 Mon Sep 17 00:00:00 2001 From: Claudio Maggioni Date: Sat, 9 May 2020 18:35:28 +0200 Subject: [PATCH 09/10] Sonarqube fixes to tests --- .../controller/ButtonDimmerController.java | 12 +- .../controller/RegularLightController.java | 2 - .../controller/ScenePriorityController.java | 3 +- .../controller/ThermostatController.java | 1 - .../controller/UserAccountController.java | 6 +- .../smarthut/dto/SceneSaveRequest.java | 2 +- .../smarthut/models/Automation.java | 4 - .../smarthut/models/ScenePriority.java | 2 - .../sanmarinoes/smarthut/models/Switch.java | 1 + .../smarthut/socket/SensorSocketEndpoint.java | 4 +- .../smarthut/AuthenticationTests.java | 132 ++++++------------ .../sanmarinoes/smarthut/SmartHutTest.java | 7 +- 12 files changed, 61 insertions(+), 115 deletions(-) diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ButtonDimmerController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ButtonDimmerController.java index e2bc359..54ea066 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ButtonDimmerController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ButtonDimmerController.java @@ -58,13 +58,11 @@ public class ButtonDimmerController .findByIdAndUsername(bd.getId(), principal.getName()) .orElseThrow(NotFoundException::new); - switch (bd.getDimType()) { - case UP: - buttonDimmer.increaseIntensity(); - break; - case DOWN: - buttonDimmer.decreaseIntensity(); - break; + if (bd.getDimType() == ButtonDimmerDimRequest.DimType.UP) { + + buttonDimmer.increaseIntensity(); + } else { + buttonDimmer.decreaseIntensity(); } deviceService.saveAllAsOwner(buttonDimmer.getOutputs(), principal.getName()); diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/RegularLightController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/RegularLightController.java index 3768cb4..c3bdc8b 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/RegularLightController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/RegularLightController.java @@ -97,8 +97,6 @@ public class RegularLightController extends GuestEnabledController deviceService.deleteByIdAsOwner(id, principal.getName()); } - // the full url should be: "/regularLight/{id}/state?sceneId={sceneId} - // however it is not necessary to specify the query in the mapping @PostMapping("/{id}/state") public State sceneBinding( @PathVariable("id") long deviceId, diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ScenePriorityController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ScenePriorityController.java index 1449727..98ead6a 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ScenePriorityController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ScenePriorityController.java @@ -25,8 +25,7 @@ public class ScenePriorityController { @Autowired ScenePriorityRepository scenePriorityRepository; @GetMapping("/{automationId}") - public List getByAutomationId(@PathVariable long automationId) - throws NotFoundException { + public List getByAutomationId(@PathVariable long automationId) { return scenePriorityRepository.findAllByAutomationId(automationId); } diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ThermostatController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ThermostatController.java index 386e1ca..0696822 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ThermostatController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/ThermostatController.java @@ -30,7 +30,6 @@ public class ThermostatController { newT.setRoomId(t.getRoomId()); newT.setUseExternalSensors(t.isUseExternalSensors()); newT.setOn(false); - System.out.println(newT); thermostatService.populateMeasuredTemperature(newT); newT = thermostatRepository.save(newT); diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/UserAccountController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/UserAccountController.java index 2432a13..c5ecfb1 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/UserAccountController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/UserAccountController.java @@ -155,10 +155,8 @@ public class UserAccountController { * @throws EmailTokenNotFoundException if given token is not a valid token for password reset */ @PutMapping("/reset-password") - public void resetPassword( - @Valid @RequestBody PasswordResetRequest resetRequest, - final HttpServletResponse response) - throws EmailTokenNotFoundException, IOException { + public void resetPassword(@Valid @RequestBody PasswordResetRequest resetRequest) + throws EmailTokenNotFoundException { final ConfirmationToken token = confirmationTokenRepository.findByConfirmationToken( resetRequest.getConfirmationToken()); diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/dto/SceneSaveRequest.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/dto/SceneSaveRequest.java index e7ce3ad..b890536 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/dto/SceneSaveRequest.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/dto/SceneSaveRequest.java @@ -1,8 +1,8 @@ package ch.usi.inf.sa4.sanmarinoes.smarthut.dto; import ch.usi.inf.sa4.sanmarinoes.smarthut.models.Icon; -import com.sun.istack.NotNull; import javax.persistence.Column; +import javax.validation.constraints.NotNull; public class SceneSaveRequest { diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Automation.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Automation.java index e17e870..4d01cde 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Automation.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Automation.java @@ -43,10 +43,6 @@ public class Automation { this.id = id; } - public Set> getStates() { - return triggers; - } - public Set getScenes() { return scenes; } diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/ScenePriority.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/ScenePriority.java index 0e05a0a..e975d08 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/ScenePriority.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/ScenePriority.java @@ -28,7 +28,6 @@ public class ScenePriority { private Automation automation; @Column(name = "automation_id", nullable = false) - @NotNull private Long automationId; @NotNull @@ -42,7 +41,6 @@ public class ScenePriority { private Scene scene; @Column(name = "scene_id", nullable = false, updatable = false) - @NotNull private Long sceneId; public long getId() { diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Switch.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Switch.java index 82ab671..359ecad 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Switch.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/Switch.java @@ -60,6 +60,7 @@ public class Switch extends InputDevice implements BooleanTriggerable, Connectab return on; } + @Override public Set getOutputs() { return switchables; } diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/socket/SensorSocketEndpoint.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/socket/SensorSocketEndpoint.java index cec40f2..cc298d4 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/socket/SensorSocketEndpoint.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/socket/SensorSocketEndpoint.java @@ -132,8 +132,8 @@ public class SensorSocketEndpoint extends Endpoint { try { username = jwtTokenUtils.getUsernameFromToken(protocolString); - } catch (Throwable ignored) { - System.out.println("Token format not valid"); + } catch (Exception ignored) { + logger.info("Token format not valid"); return null; } diff --git a/src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/AuthenticationTests.java b/src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/AuthenticationTests.java index 5eac647..2c0ae6f 100644 --- a/src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/AuthenticationTests.java +++ b/src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/AuthenticationTests.java @@ -5,7 +5,6 @@ import static org.assertj.core.api.Assertions.assertThat; import ch.usi.inf.sa4.sanmarinoes.smarthut.dto.JWTRequest; import ch.usi.inf.sa4.sanmarinoes.smarthut.dto.JWTResponse; import ch.usi.inf.sa4.sanmarinoes.smarthut.dto.UserRegistrationRequest; -import ch.usi.inf.sa4.sanmarinoes.smarthut.error.DuplicateRegistrationException; import ch.usi.inf.sa4.sanmarinoes.smarthut.error.UnauthorizedException; import ch.usi.inf.sa4.sanmarinoes.smarthut.models.ConfirmationTokenRepository; import ch.usi.inf.sa4.sanmarinoes.smarthut.models.UserRepository; @@ -44,7 +43,7 @@ public class AuthenticationTests extends SmartHutTest { final ResponseEntity res = this.restTemplate.postForEntity( this.url("/register"), getDisabledUser(), Object.class); - assertThat(res.getStatusCode().equals(HttpStatus.OK)); + assertThat(res.getStatusCode()).isEqualTo(HttpStatus.OK); registerTestUser(restTemplate, userRepository, tokenRepository); } @@ -54,10 +53,11 @@ public class AuthenticationTests extends SmartHutTest { final Map badJSON = Map.of("luciano", "goretti", "danilo", "malusa"); assertThat( - this.restTemplate - .postForEntity(url("/register"), badJSON, JWTResponse.class) - .getStatusCode() - .equals(HttpStatus.BAD_REQUEST)); + this.restTemplate + .postForEntity(url("/register"), badJSON, JWTResponse.class) + .getStatusCode() + .equals(HttpStatus.BAD_REQUEST)) + .isTrue(); } @Test @@ -70,12 +70,15 @@ public class AuthenticationTests extends SmartHutTest { final ResponseEntity res = this.restTemplate.postForEntity(url("/register"), request, JsonObject.class); - assertThat(res.getStatusCode().equals(HttpStatus.BAD_REQUEST)); - assertThat(res.getBody() != null); + assertThat(res.getStatusCode().equals(HttpStatus.BAD_REQUEST)).isTrue(); + assertThat(res.getBody()).isNotNull(); final JsonArray errors = res.getBody().getAsJsonArray("errors"); - assertThat(errors.size() == 1); - assertThat(errors.get(0).getAsJsonObject().get("field").getAsString().equals("password")); + assertThat(errors) + .allSatisfy( + e -> + assertThat(e.getAsJsonObject().get("field").getAsString()) + .isEqualTo("password")); } @Test @@ -88,12 +91,15 @@ public class AuthenticationTests extends SmartHutTest { final ResponseEntity res = this.restTemplate.postForEntity(url("/register"), request, JsonObject.class); - assertThat(res.getStatusCode().equals(HttpStatus.BAD_REQUEST)); - assertThat(res.getBody() != null); + assertThat(res.getStatusCode().equals(HttpStatus.BAD_REQUEST)).isTrue(); + assertThat(res.getBody()).isNotNull(); final JsonArray errors = res.getBody().getAsJsonArray("errors"); - assertThat(errors.size() == 1); - assertThat(errors.get(0).getAsJsonObject().get("field").getAsString().equals("email")); + assertThat(errors) + .allSatisfy( + e -> + assertThat(e.getAsJsonObject().get("field").getAsString()) + .isEqualTo("email")); } @Test @@ -105,12 +111,15 @@ public class AuthenticationTests extends SmartHutTest { final ResponseEntity res = this.restTemplate.postForEntity(url("/register"), request, JsonObject.class); - assertThat(res.getStatusCode().equals(HttpStatus.BAD_REQUEST)); - assertThat(res.getBody() != null); + assertThat(res.getStatusCode().equals(HttpStatus.BAD_REQUEST)).isTrue(); + assertThat(res.getBody() != null).isTrue(); final JsonArray errors = res.getBody().getAsJsonArray("errors"); - assertThat(errors.size() == 1); - assertThat(errors.get(0).getAsJsonObject().get("field").getAsString().equals("name")); + assertThat(errors) + .allSatisfy( + e -> + assertThat(e.getAsJsonObject().get("field").getAsString()) + .isEqualTo("name")); } @Test @@ -122,51 +131,15 @@ public class AuthenticationTests extends SmartHutTest { final ResponseEntity res = this.restTemplate.postForEntity(url("/register"), request, JsonObject.class); - assertThat(res.getStatusCode().equals(HttpStatus.BAD_REQUEST)); - assertThat(res.getBody() != null); + assertThat(res.getStatusCode().equals(HttpStatus.BAD_REQUEST)).isTrue(); + assertThat(res.getBody() != null).isTrue(); final JsonArray errors = res.getBody().getAsJsonArray("errors"); - assertThat(errors.size() == 1); - assertThat(errors.get(0).getAsJsonObject().get("field").getAsString().equals("username")); - } - - @Test - public void registrationShouldReturnBadRequestWithDuplicateData() { - { - final ResponseEntity res = - this.restTemplate.postForEntity( - url("/register"), - getDisabledUser(), - DuplicateRegistrationException.class); - assertThat(res.getStatusCode().equals(HttpStatus.BAD_REQUEST)); - assertThat(res.getBody() != null); - } - - { - final UserRegistrationRequest disabledUserDifferentMail = getDisabledUser(); - enabledUser.setEmail("another@example.com"); - - final ResponseEntity res = - this.restTemplate.postForEntity( - url("/register"), - disabledUserDifferentMail, - DuplicateRegistrationException.class); - assertThat(res.getStatusCode().equals(HttpStatus.BAD_REQUEST)); - assertThat(res.getBody() != null); - } - - { - final UserRegistrationRequest disabledUserDifferentUsername = getDisabledUser(); - enabledUser.setUsername("another"); - - final ResponseEntity res = - this.restTemplate.postForEntity( - url("/register"), - disabledUserDifferentUsername, - DuplicateRegistrationException.class); - assertThat(res.getStatusCode().equals(HttpStatus.BAD_REQUEST)); - assertThat(res.getBody() != null); - } + assertThat(errors) + .allSatisfy( + j -> + assertThat(j.getAsJsonObject().get("field").getAsString()) + .isEqualTo("username")); } @Test @@ -179,8 +152,7 @@ public class AuthenticationTests extends SmartHutTest { final ResponseEntity res = this.restTemplate.postForEntity(url("/register"), request, Object.class); - assertThat(res.getStatusCode().equals(HttpStatus.OK)); - assertThat(res.getBody() != null); + assertThat(res.getStatusCode()).isEqualTo(HttpStatus.OK); } @Test @@ -188,10 +160,11 @@ public class AuthenticationTests extends SmartHutTest { final Map badJSON = Map.of("badkey", 3, "password", "ciaomamma"); assertThat( - this.restTemplate - .postForEntity(url("/auth/login"), badJSON, JWTResponse.class) - .getStatusCode() - .equals(HttpStatus.BAD_REQUEST)); + this.restTemplate + .postForEntity(url("/auth/login"), badJSON, JWTResponse.class) + .getStatusCode() + .equals(HttpStatus.BAD_REQUEST)) + .isTrue(); } @Test @@ -203,9 +176,9 @@ public class AuthenticationTests extends SmartHutTest { final ResponseEntity res = this.restTemplate.postForEntity( url("/auth/login"), request, UnauthorizedException.class); - assertThat(res.getStatusCode().equals(HttpStatus.UNAUTHORIZED)); - assertThat(res.getBody() != null); - assertThat(!res.getBody().isUserDisabled()); + assertThat(res.getStatusCode().equals(HttpStatus.UNAUTHORIZED)).isTrue(); + assertThat(res.getBody() != null).isTrue(); + assertThat(!res.getBody().isUserDisabled()).isTrue(); } @Test @@ -217,22 +190,7 @@ public class AuthenticationTests extends SmartHutTest { final ResponseEntity res = this.restTemplate.postForEntity( url("/auth/login"), request, UnauthorizedException.class); - assertThat(res.getStatusCode().equals(HttpStatus.UNAUTHORIZED)); - assertThat(res.getBody() != null); - assertThat(res.getBody().isUserDisabled()); - } - - @Test - public void loginShouldReturnTokenWithEnabledUser() { - final JWTRequest request = new JWTRequest(); - request.setUsernameOrEmail("enabled"); - request.setPassword("password"); - - final ResponseEntity res = - this.restTemplate.postForEntity(url("/auth/login"), request, JWTResponse.class); - assertThat(res.getStatusCode().equals(HttpStatus.OK)); - assertThat(res.getBody() != null); - assertThat(res.getBody().getToken() != null); - assertThat(!res.getBody().getToken().isEmpty()); + assertThat(res.getStatusCode()).isEqualTo(HttpStatus.UNAUTHORIZED); + assertThat(res.getBody()).isNotNull(); } } diff --git a/src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/SmartHutTest.java b/src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/SmartHutTest.java index 69a7ba1..445bf08 100644 --- a/src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/SmartHutTest.java +++ b/src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/SmartHutTest.java @@ -14,7 +14,7 @@ import org.springframework.http.ResponseEntity; import org.springframework.web.reactive.function.client.WebClient; public abstract class SmartHutTest { - private boolean setupDone = false; + private static boolean setupDone = false; protected final String getBaseURL() { return "http://localhost:2000/"; @@ -54,8 +54,9 @@ public abstract class SmartHutTest { .toBodilessEntity() .block(); - assertThat(res3.getStatusCode().is2xxSuccessful()); - assertThat(userRepository.findByUsername("enabled").getEnabled()); + assertThat(res3).isNotNull(); + assertThat(res3.getStatusCode()).isEqualTo(HttpStatus.FOUND); + assertThat(userRepository.findByUsername("enabled").getEnabled()).isTrue(); } @BeforeEach From 483a42b1e0efc3469f7a24feff67cbc6928f072a Mon Sep 17 00:00:00 2001 From: "Claudio Maggioni (maggicl)" Date: Sun, 10 May 2020 00:38:13 +0200 Subject: [PATCH 10/10] Even another batch of sonar fixes --- .../smarthut/controller/AutomationController.java | 3 ++- .../sanmarinoes/smarthut/models/ConfirmationToken.java | 4 ++-- .../sa4/sanmarinoes/smarthut/service/DeviceService.java | 8 ++++++-- .../smarthut/service/JWTUserDetailsService.java | 2 +- .../sanmarinoes/smarthut/socket/SensorSocketConfig.java | 4 ++-- .../smarthut/socket/SensorSocketEndpoint.java | 3 ++- .../usi/inf/sa4/sanmarinoes/smarthut/SmartHutTest.java | 2 +- .../sanmarinoes/smarthut/SmarthutApplicationTests.java | 9 +++------ 8 files changed, 19 insertions(+), 16 deletions(-) diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/AutomationController.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/AutomationController.java index c3027ae..af5f727 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/AutomationController.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/AutomationController.java @@ -99,7 +99,7 @@ public class AutomationController { req.getScenes() .stream() .map(AutomationFastUpdateRequest.ScenePriorityDTO::toModel) - .peek( + .map( t -> { t.setAutomationId(a.getId()); @@ -107,6 +107,7 @@ public class AutomationController { // please do not replicate unless the quality gate sees // it as a bug t.setAutomation(a); + return t; }) .collect(Collectors.toList())); diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/ConfirmationToken.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/ConfirmationToken.java index ac1f151..1aea856 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/ConfirmationToken.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/models/ConfirmationToken.java @@ -53,7 +53,7 @@ public class ConfirmationToken { } public Date getCreatedDate() { - return createdDate; + return (Date) createdDate.clone(); } public User getUser() { @@ -69,7 +69,7 @@ public class ConfirmationToken { } public void setCreatedDate(Date createdDate) { - this.createdDate = createdDate; + this.createdDate = (Date) createdDate.clone(); } public void setUser(User user) { diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/DeviceService.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/DeviceService.java index bf16b88..3678bc0 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/DeviceService.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/DeviceService.java @@ -75,7 +75,7 @@ public class DeviceService { sceneRepository .findById(t.getSceneId()) .orElseThrow(IllegalStateException::new)) - .forEach((s) -> sceneService.apply(s, username, true)); + .forEach(s -> sceneService.apply(s, username, true)); } public List findAll(Long hostId, String username) throws NotFoundException { @@ -123,7 +123,7 @@ public class DeviceService { List toReturn = devicePropagationService.saveAllAsOwner(devices, username, fromScene, fromTrigger); if (!fromScene) { - toReturn.forEach((d) -> this.triggerTriggers(d, username)); + toReturn.forEach(d -> this.triggerTriggers(d, username)); } return toReturn; } @@ -170,6 +170,10 @@ public class DeviceService { devicePopulationService.populateComputedFields(devices); + return filterOutCamerasIfNeeded(host, devices); + } + + private List filterOutCamerasIfNeeded(User host, Iterable devices) { if (host != null && !host.isCameraEnabled()) { return StreamSupport.stream(devices.spliterator(), true) .filter(d -> !(d instanceof SecurityCamera)) diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/JWTUserDetailsService.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/JWTUserDetailsService.java index 8ab5f8a..f8c8e5b 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/JWTUserDetailsService.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/service/JWTUserDetailsService.java @@ -15,7 +15,7 @@ public class JWTUserDetailsService implements UserDetailsService { @Autowired private UserRepository repository; @Override - public UserDetails loadUserByUsername(String username) throws UsernameNotFoundException { + public UserDetails loadUserByUsername(String username) { User toReturn = repository.findByUsername(username); if (toReturn != null && toReturn.getEnabled()) { return new org.springframework.security.core.userdetails.User( diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/socket/SensorSocketConfig.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/socket/SensorSocketConfig.java index 503667a..e1b29ce 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/socket/SensorSocketConfig.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/socket/SensorSocketConfig.java @@ -42,8 +42,8 @@ public class SensorSocketConfig extends ServerEndpointConfig.Configurator { public T getEndpointInstance(Class endpointClass) throws InstantiationException { try { @SuppressWarnings("unchecked") - final T instance = (T) this.instance; - return instance; + final T thaInstance = (T) this.instance; + return thaInstance; } catch (ClassCastException e) { final var e2 = new InstantiationException("Cannot cast SensorSocketEndpoint to desired type"); diff --git a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/socket/SensorSocketEndpoint.java b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/socket/SensorSocketEndpoint.java index cc298d4..009dfab 100644 --- a/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/socket/SensorSocketEndpoint.java +++ b/src/main/java/ch/usi/inf/sa4/sanmarinoes/smarthut/socket/SensorSocketEndpoint.java @@ -122,7 +122,8 @@ public class SensorSocketEndpoint extends Endpoint { } else { try { session.close(); - } catch (IOException ignored) { + } catch (IOException e) { + logger.warn(e.getLocalizedMessage(), e); } } } diff --git a/src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/SmartHutTest.java b/src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/SmartHutTest.java index 445bf08..1b3c96b 100644 --- a/src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/SmartHutTest.java +++ b/src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/SmartHutTest.java @@ -41,7 +41,7 @@ public abstract class SmartHutTest { final ConfirmationTokenRepository tokenRepository) { final ResponseEntity res2 = restTemplate.postForEntity(this.url("/register"), enabledUser, Object.class); - assertThat(res2.getStatusCode().equals(HttpStatus.OK)); + assertThat(res2.getStatusCode()).isEqualTo(HttpStatus.OK); final User persistedEnabledUser = userRepository.findByUsername("enabled"); final ConfirmationToken token = tokenRepository.findByUser(persistedEnabledUser); diff --git a/src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/SmarthutApplicationTests.java b/src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/SmarthutApplicationTests.java index dbd7e21..2aaa1b1 100644 --- a/src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/SmarthutApplicationTests.java +++ b/src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/SmarthutApplicationTests.java @@ -16,11 +16,8 @@ public class SmarthutApplicationTests extends SmartHutTest { @Autowired private TestRestTemplate restTemplate; @Test - public void anonymousGreetingShouldNotBeAuthorized() throws Exception { - assertThat( - this.restTemplate - .getForEntity(getBaseURL(), Void.class) - .getStatusCode() - .equals(HttpStatus.UNAUTHORIZED)); + public void anonymousGreetingShouldNotBeAuthorized() { + assertThat(this.restTemplate.getForEntity(getBaseURL(), Void.class).getStatusCode()) + .isEqualTo(HttpStatus.UNAUTHORIZED); } }