Merge branch '83-dimmablelightcontrollertests' into 'dev'
Resolve "DimmableLightControllerTests" Closes #83 See merge request sa4-2020/the-sanmarinoes/backend!178
This commit is contained in:
commit
2372d51efc
1 changed files with 171 additions and 0 deletions
|
@ -0,0 +1,171 @@
|
||||||
|
package ch.usi.inf.sa4.sanmarinoes.smarthut.controller;
|
||||||
|
|
||||||
|
import static org.assertj.core.api.Assertions.assertThat;
|
||||||
|
import static org.assertj.core.api.Assertions.assertThatThrownBy;
|
||||||
|
import static org.mockito.ArgumentMatchers.any;
|
||||||
|
import static org.mockito.ArgumentMatchers.anyLong;
|
||||||
|
import static org.mockito.ArgumentMatchers.eq;
|
||||||
|
import static org.mockito.Mockito.doNothing;
|
||||||
|
import static org.mockito.Mockito.when;
|
||||||
|
|
||||||
|
import ch.usi.inf.sa4.sanmarinoes.smarthut.dto.DimmableSaveRequest;
|
||||||
|
import ch.usi.inf.sa4.sanmarinoes.smarthut.error.DuplicateStateException;
|
||||||
|
import ch.usi.inf.sa4.sanmarinoes.smarthut.error.NotFoundException;
|
||||||
|
import ch.usi.inf.sa4.sanmarinoes.smarthut.models.*;
|
||||||
|
import ch.usi.inf.sa4.sanmarinoes.smarthut.service.DeviceService;
|
||||||
|
import java.security.Principal;
|
||||||
|
import java.util.Optional;
|
||||||
|
import lombok.SneakyThrows;
|
||||||
|
import org.junit.jupiter.api.Assertions;
|
||||||
|
import org.junit.jupiter.api.BeforeEach;
|
||||||
|
import org.junit.jupiter.api.DisplayName;
|
||||||
|
import org.junit.jupiter.api.Test;
|
||||||
|
import org.junit.jupiter.api.extension.ExtendWith;
|
||||||
|
import org.mockito.InjectMocks;
|
||||||
|
import org.mockito.Mock;
|
||||||
|
import org.mockito.junit.jupiter.MockitoExtension;
|
||||||
|
import org.springframework.mock.web.MockHttpServletRequest;
|
||||||
|
import org.springframework.security.test.context.support.WithMockUser;
|
||||||
|
import org.springframework.web.context.request.RequestContextHolder;
|
||||||
|
import org.springframework.web.context.request.ServletRequestAttributes;
|
||||||
|
|
||||||
|
@ExtendWith(MockitoExtension.class)
|
||||||
|
@WithMockUser(username = "user")
|
||||||
|
public class DimmableLightControllerTests {
|
||||||
|
|
||||||
|
@InjectMocks private DimmableLightController dimmableLightController;
|
||||||
|
|
||||||
|
@Mock private DimmableLightRepository dimmableLightRepository;
|
||||||
|
|
||||||
|
@Mock private SceneRepository sceneRepository;
|
||||||
|
|
||||||
|
@Mock private StateRepository<State> stateRepository;
|
||||||
|
|
||||||
|
@Mock private DeviceService deviceService;
|
||||||
|
|
||||||
|
@Mock private Principal mockPrincipal;
|
||||||
|
|
||||||
|
@Mock private UserRepository userRepository;
|
||||||
|
|
||||||
|
@Mock private DeviceRepository<DimmableLight> deviceRepository;
|
||||||
|
|
||||||
|
@BeforeEach
|
||||||
|
public void setup() {
|
||||||
|
when(mockPrincipal.getName()).thenReturn("user");
|
||||||
|
}
|
||||||
|
|
||||||
|
private void checkDimmableLightAgainstRequest(
|
||||||
|
final DimmableLight toCheck, final DimmableSaveRequest request) {
|
||||||
|
assertThat(toCheck).isNotNull();
|
||||||
|
assertThat(toCheck.getIntensity()).isEqualTo(request.getIntensity());
|
||||||
|
assertThat(toCheck.getName()).isEqualTo(request.getName());
|
||||||
|
assertThat(toCheck.getRoomId()).isEqualTo(request.getRoomId());
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
@DisplayName("when creating should return the same object")
|
||||||
|
@SneakyThrows(NotFoundException.class)
|
||||||
|
public void testCreate() {
|
||||||
|
doNothing().when(deviceService).throwIfRoomNotOwned(anyLong(), eq("user"));
|
||||||
|
when(deviceService.saveAsOwner(any(DimmableLight.class), eq("user")))
|
||||||
|
.thenAnswer(i -> i.getArguments()[0]);
|
||||||
|
|
||||||
|
MockHttpServletRequest request = new MockHttpServletRequest();
|
||||||
|
RequestContextHolder.setRequestAttributes(new ServletRequestAttributes(request));
|
||||||
|
|
||||||
|
final DimmableSaveRequest toSend = new DimmableSaveRequest();
|
||||||
|
toSend.setName("rl");
|
||||||
|
toSend.setRoomId(20L);
|
||||||
|
toSend.setIntensity(35);
|
||||||
|
|
||||||
|
final DimmableLight regularLight = dimmableLightController.create(toSend, mockPrincipal);
|
||||||
|
|
||||||
|
checkDimmableLightAgainstRequest(regularLight, toSend);
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
@DisplayName("when updating should return the same object")
|
||||||
|
@SneakyThrows(NotFoundException.class)
|
||||||
|
public void testUpdate() {
|
||||||
|
|
||||||
|
final DimmableSaveRequest toSend = new DimmableSaveRequest();
|
||||||
|
toSend.setId(50L);
|
||||||
|
toSend.setName("rl");
|
||||||
|
toSend.setRoomId(20L);
|
||||||
|
toSend.setIntensity(35);
|
||||||
|
|
||||||
|
final DimmableLight toUpdate = new DimmableLight();
|
||||||
|
toUpdate.setName("OOO");
|
||||||
|
toUpdate.setRoomId(40L);
|
||||||
|
toSend.setId(50L);
|
||||||
|
toUpdate.setOn(false);
|
||||||
|
|
||||||
|
when(dimmableLightRepository.findByIdAndUserId(anyLong(), anyLong()))
|
||||||
|
.thenReturn(java.util.Optional.of(toUpdate));
|
||||||
|
|
||||||
|
when(deviceService.saveAsGuest(any(DimmableLight.class), eq("user"), anyLong()))
|
||||||
|
.thenAnswer(i -> i.getArguments()[0]);
|
||||||
|
|
||||||
|
User guest = new User();
|
||||||
|
User host = new User();
|
||||||
|
host.getGuests().add(guest);
|
||||||
|
guest.getHosts().add(host);
|
||||||
|
|
||||||
|
when(userRepository.findById(20L)).thenReturn(Optional.of(host));
|
||||||
|
when(userRepository.findByUsername("user")).thenReturn(guest);
|
||||||
|
|
||||||
|
MockHttpServletRequest request = new MockHttpServletRequest();
|
||||||
|
RequestContextHolder.setRequestAttributes(new ServletRequestAttributes(request));
|
||||||
|
|
||||||
|
final DimmableLight dimmableLight =
|
||||||
|
dimmableLightController.update(toSend, mockPrincipal, 20L);
|
||||||
|
|
||||||
|
checkDimmableLightAgainstRequest(dimmableLight, toSend);
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
@DisplayName("an existing id should succeed")
|
||||||
|
@SneakyThrows(NotFoundException.class)
|
||||||
|
public void testDelete() {
|
||||||
|
|
||||||
|
doNothing().when(deviceService).deleteByIdAsOwner(eq(42L), eq("user"));
|
||||||
|
|
||||||
|
MockHttpServletRequest request = new MockHttpServletRequest();
|
||||||
|
RequestContextHolder.setRequestAttributes(new ServletRequestAttributes(request));
|
||||||
|
|
||||||
|
Assertions.assertDoesNotThrow(() -> dimmableLightController.delete(42L, mockPrincipal));
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void testSceneBinding() {
|
||||||
|
DimmableLight dimmableLight = new DimmableLight();
|
||||||
|
when(dimmableLightRepository.findByIdAndUsername(24L, "user"))
|
||||||
|
.thenReturn(Optional.of(dimmableLight));
|
||||||
|
Scene scene = new Scene();
|
||||||
|
scene.setId(1L);
|
||||||
|
DimmableState state = new DimmableState();
|
||||||
|
state.setSceneId(1L);
|
||||||
|
State s = dimmableLight.cloneState();
|
||||||
|
when(sceneRepository.findById(1L)).thenReturn(Optional.of(scene));
|
||||||
|
when(stateRepository.countByDeviceIdAndSceneId(24L, 1L)).thenReturn(0);
|
||||||
|
Assertions.assertDoesNotThrow(
|
||||||
|
() -> dimmableLightController.sceneBinding(24L, 1L, mockPrincipal));
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void testSceneBinding2() {
|
||||||
|
when(mockPrincipal.getName()).thenReturn("user");
|
||||||
|
DimmableLight dimmableLight = new DimmableLight();
|
||||||
|
when(dimmableLightRepository.findByIdAndUsername(24L, "user"))
|
||||||
|
.thenReturn(Optional.of(dimmableLight));
|
||||||
|
Scene scene = new Scene();
|
||||||
|
scene.setId(1L);
|
||||||
|
DimmableState state = new DimmableState();
|
||||||
|
state.setSceneId(1L);
|
||||||
|
State s = dimmableLight.cloneState();
|
||||||
|
when(sceneRepository.findById(1L)).thenReturn(Optional.of(scene));
|
||||||
|
when(stateRepository.countByDeviceIdAndSceneId(24L, 1L)).thenReturn(2);
|
||||||
|
assertThatThrownBy(() -> dimmableLightController.sceneBinding(24L, 1L, mockPrincipal))
|
||||||
|
.isInstanceOf(DuplicateStateException.class);
|
||||||
|
}
|
||||||
|
}
|
Loading…
Reference in a new issue