smarthut/backend
2
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

device controller is covered (yay)

Browse source
This commit is contained in:
Tommaso Rodolfo Masera 2020-05-26 16:07:46 +02:00
parent 7d974f1a1d
commit f784796852
1 changed files with 52 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

66
src/test/java/ch/usi/inf/sa4/sanmarinoes/smarthut/controller/DeviceControllerTests.java
View file

@ -1,7 +1,8 @@
package ch.usi.inf.sa4.sanmarinoes.smarthut.controller; package ch.usi.inf.sa4.sanmarinoes.smarthut.controller;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.when; import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.mockito.Mockito.*;
import ch.usi.inf.sa4.sanmarinoes.smarthut.dto.DeviceSaveRequest; import ch.usi.inf.sa4.sanmarinoes.smarthut.dto.DeviceSaveRequest;
import ch.usi.inf.sa4.sanmarinoes.smarthut.error.BadDataException; import ch.usi.inf.sa4.sanmarinoes.smarthut.error.BadDataException;
@ -10,6 +11,7 @@ import ch.usi.inf.sa4.sanmarinoes.smarthut.models.*;
import ch.usi.inf.sa4.sanmarinoes.smarthut.service.DeviceService; import ch.usi.inf.sa4.sanmarinoes.smarthut.service.DeviceService;
import java.security.Principal; import java.security.Principal;
import java.util.List; import java.util.List;
import java.util.Optional;
import lombok.SneakyThrows; import lombok.SneakyThrows;
import org.junit.jupiter.api.DisplayName; import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
@ -43,22 +45,58 @@ public class DeviceControllerTests {
@DisplayName("check update device") @DisplayName("check update device")
@Test @Test
@SneakyThrows(NotFoundException.class) public void updateDeviceRepositoryTest() {
public void updateTest() throws BadDataException {
DeviceSaveRequest dto = new DeviceSaveRequest(); DeviceSaveRequest dto = new DeviceSaveRequest();
dto.setId(22L); dto.setId(3L);
dto.setName("DTO"); dto.setName("dto");
dto.setRoomId(room.getId()); dto.setRoomId(room.getId());
when(mockPrincipal.getName()).thenReturn("user");
assertThat(deviceRepository.findByIdAndUsername(34L, mockPrincipal.getName())).isEmpty();
Device d = new RegularLight(); when(deviceRepository.findByIdAndUsername(dto.getId(), mockPrincipal.getName()))
deviceService.saveAsOwner(d, mockPrincipal.getName()); .thenReturn(Optional.empty());
d = deviceController.update(dto, mockPrincipal);
assertThat(deviceRepository.findByIdAndUsername(dto.getId(), mockPrincipal.getName())) assertThatThrownBy(() -> deviceController.update(dto, mockPrincipal))
.isSameAs(d); .isInstanceOf(NotFoundException.class);
assertThat(d.getRoomId()).isSameAs(dto.getRoomId()); }
assertThat(d.getName()).isSameAs(dto.getName());
@DisplayName("check update device")
@Test
public void updateRoomRepositoryTest() {
DeviceSaveRequest dto = new DeviceSaveRequest();
dto.setId(3L);
dto.setName("dto");
dto.setRoomId(room.getId());
when(deviceRepository.findByIdAndUsername(dto.getId(), mockPrincipal.getName()))
.thenReturn(Optional.of(new RegularLight()));
when(roomRepository.findByIdAndUsername(room.getId(), mockPrincipal.getName()))
.thenReturn(Optional.empty());
assertThatThrownBy(() -> deviceController.update(dto, mockPrincipal))
.isInstanceOf(BadDataException.class);
}
@DisplayName("check update device")
@Test
@SneakyThrows({NotFoundException.class, BadDataException.class})
public void updateTest() {
DeviceSaveRequest dto = new DeviceSaveRequest();
dto.setId(3L);
dto.setName("dto");
dto.setRoomId(room.getId());
Device rl = new RegularLight();
rl.setRoomId(dto.getRoomId());
rl.setName(dto.getName());
when(deviceRepository.findByIdAndUsername(dto.getId(), mockPrincipal.getName()))
.thenReturn(Optional.of(rl));
when(roomRepository.findByIdAndUsername(room.getId(), mockPrincipal.getName()))
.thenReturn(Optional.of(room));
when(deviceService.saveAsOwner(rl, mockPrincipal.getName())).thenReturn(rl);
Device returned = deviceController.update(dto, mockPrincipal);
assertThat(returned.getRoomId()).isSameAs(rl.getRoomId());
assertThat(returned.getName()).isSameAs(rl.getName());
} }
@DisplayName("check if list is empty") @DisplayName("check if list is empty")