From a7f05f0200bd46abed28a163991d970de8c34a86 Mon Sep 17 00:00:00 2001
From: britea <andreabritesma@gmail.com>
Date: Mon, 27 Apr 2020 15:47:59 +0200
Subject: [PATCH] fixed scenes

---
 .../src/components/dashboard/ScenesPanel.js   |   5 +-
 .../components/dashboard/devices/Curtain.js   | 203 +++++++++---------
 .../components/dashboard/devices/Device.js    |  90 +++-----
 .../dashboard/devices/DeviceSettingsModal.js  |   4 +-
 .../src/components/dashboard/devices/Light.js |   4 +-
 .../components/dashboard/devices/Sensor.js    |  13 +-
 .../components/dashboard/devices/SmartPlug.js |  19 +-
 .../dashboard/devices/Thermostats.js          |  19 +-
 smart-hut/src/remote.js                       |   2 +-
 9 files changed, 176 insertions(+), 183 deletions(-)

diff --git a/smart-hut/src/components/dashboard/ScenesPanel.js b/smart-hut/src/components/dashboard/ScenesPanel.js
index 4060e9a..d8bcfd5 100644
--- a/smart-hut/src/components/dashboard/ScenesPanel.js
+++ b/smart-hut/src/components/dashboard/ScenesPanel.js
@@ -8,13 +8,14 @@ import { Grid, Button } from "semantic-ui-react";
 class ScenesPanel extends Component {
   constructor(props) {
     super(props);
-
     this.applyScene = this.applyScene.bind(this);
   }
 
   applyScene() {
     console.log(this.props.activeScene);
-    this.props.sceneApply(this.props.activeScene);
+    this.props.sceneApply(this.props.activeScene).then(() => {
+      alert("Scene applied.");
+    });
   }
 
   render() {
diff --git a/smart-hut/src/components/dashboard/devices/Curtain.js b/smart-hut/src/components/dashboard/devices/Curtain.js
index 322e43c..37920ce 100644
--- a/smart-hut/src/components/dashboard/devices/Curtain.js
+++ b/smart-hut/src/components/dashboard/devices/Curtain.js
@@ -4,116 +4,123 @@ import { RemoteService } from "../../../remote";
 import { connect } from "react-redux";
 
 class Curtain extends Component {
-    constructor(props) {
-        super(props);
-        this.state = { intensity: this.props.stateOrDevice.intensity, timeout: null };
-
-        this.setIntensity = this.setIntensity.bind(this);
-    }
-
-    //getters
-    get turnedOn() {
-        return this.props.stateOrDevice.on;
-    }
-
-    get intensity() {
-        return this.props.stateOrDevice.intensity || 0;
-    }
-
-    onClickDevice = () => {
-        const on = !this.turnedOn;
-        if(this.props.tab==="Devices"){
-            this.props
-                .saveDevice({ ...this.props.stateOrDevice, on })
-                .catch((err) => console.error("curtains update error", err));
-        }else{
-            this.props.updateState({ id: this.props.sceneState.id, on: on },this.props.sceneState.kind);
-        }
+  constructor(props) {
+    super(props);
+    this.state = {
+      intensity: this.props.stateOrDevice.intensity,
+      timeout: null,
     };
 
-    setIntensity(intensity) {
-        intensity *= 100;
+    this.setIntensity = this.setIntensity.bind(this);
+  }
 
-        if (this.state.timeout) {
-            clearTimeout(this.state.timeout);
-        }
+  //getters
+  get turnedOn() {
+    return this.props.stateOrDevice.on;
+  }
 
-        this.setState({
-            intensity,
-            timeout: setTimeout(() => {
-                this.saveIntensity();
-                this.setState({
-                    intensity: this.state.intensity,
-                    timeout: null,
-                });
-            }, 100),
-        });
+  get intensity() {
+    return this.props.stateOrDevice.intensity || 0;
+  }
+
+  onClickDevice = () => {
+    const on = !this.turnedOn;
+    if (this.props.tab === "Devices") {
+      this.props
+        .saveDevice({ ...this.props.stateOrDevice, on })
+        .catch((err) => console.error("curtains update error", err));
+    } else {
+      this.props.updateState(
+        { id: this.props.stateOrDevice.id, on: on },
+        this.props.stateOrDevice.kind
+      );
+    }
+  };
+
+  setIntensity(intensity) {
+    intensity *= 100;
+
+    if (this.state.timeout) {
+      clearTimeout(this.state.timeout);
     }
 
-    saveIntensity = () => {
-        const intensity = Math.round(this.state.intensity);
-        if(this.props.tab==="Devices"){
-            this.props
-                .saveDevice({ ...this.props.stateOrDevice, intensity })
-                .catch((err) => console.error("curtain update error", err));
-        }else{
-            this.props.updateState({ id: this.props.sceneState.id, intensity: intensity },this.props.sceneState.kind);
-        }
-    };
-
-    helper = () => {
-        if (this.props.device.intensity >= 90) {
-            this.setIntensity(1);
-            this.saveIntensity();
-        } else {
-            this.setIntensity(this.props.stateOrDevice.intensity / 100 + 0.1);
-            this.saveIntensity();
-        }
-    };
-
-
-    ///*this took me way too much more time than it should have*/
-
-    handleChange = (a) => {
-        this.setIntensity(a.target.value / 100);
+    this.setState({
+      intensity,
+      timeout: setTimeout(() => {
         this.saveIntensity();
-    };
+        this.setState({
+          intensity: this.state.intensity,
+          timeout: null,
+        });
+      }, 100),
+    });
+  }
 
-    render() {
-        return (
-            <div className="container">
-                <div
-                    className="open-container"
-                    style={{
-                        height: (9 * this.props.stateOrDevice.intensity) / 100 + "rem",
-                    }}
-                ></div>{" "}
-                <span className="span-open">
-                    {Math.round(this.props.stateOrDevice.intensity)}%
-                </span>
-                <input
-                    onChange={this.handleChange}
-                    value={this.props.stateOrDevice.intensity}
-                    className="slider"
-                    type="range"
-                    min="0"
-                    max="100"
-                />
-            </div>
-
-        );
+  saveIntensity = () => {
+    const intensity = Math.round(this.state.intensity);
+    if (this.props.tab === "Devices") {
+      this.props
+        .saveDevice({ ...this.props.stateOrDevice, intensity })
+        .catch((err) => console.error("curtain update error", err));
+    } else {
+      this.props.updateState(
+        { id: this.props.stateOrDevice.id, intensity: intensity },
+        this.props.stateOrDevice.kind
+      );
     }
+  };
+
+  helper = () => {
+    if (this.props.device.intensity >= 90) {
+      this.setIntensity(1);
+      this.saveIntensity();
+    } else {
+      this.setIntensity(this.props.stateOrDevice.intensity / 100 + 0.1);
+      this.saveIntensity();
+    }
+  };
+
+  ///*this took me way too much more time than it should have*/
+
+  handleChange = (a) => {
+    this.setIntensity(a.target.value / 100);
+    this.saveIntensity();
+  };
+
+  render() {
+    return (
+      <div className="container">
+        <div
+          className="open-container"
+          style={{
+            height: (9 * this.props.stateOrDevice.intensity) / 100 + "rem",
+          }}
+        ></div>{" "}
+        <span className="span-open">
+          {Math.round(this.props.stateOrDevice.intensity)}%
+        </span>
+        <input
+          onChange={this.handleChange}
+          value={this.props.stateOrDevice.intensity}
+          className="slider"
+          type="range"
+          min="0"
+          max="100"
+        />
+      </div>
+    );
+  }
 }
 
 const mapStateToProps = (state, ownProps) => ({
-    get stateOrDevice(){
-        if(state.active.activeTab==="Devices"){
-            return state.devices[ownProps.id];
-        }else{
-            return state.sceneStates[ownProps.id];
-        }
-    },
-    //device: state.devices[ownProps.id],
+  get stateOrDevice() {
+    if (state.active.activeTab === "Devices") {
+      return state.devices[ownProps.id];
+    } else {
+      return state.sceneStates[ownProps.id];
+    }
+  },
+  //device: state.devices[ownProps.id],
 });
 const CurtainContainer = connect(mapStateToProps, RemoteService)(Curtain);
 export default CurtainContainer;
diff --git a/smart-hut/src/components/dashboard/devices/Device.js b/smart-hut/src/components/dashboard/devices/Device.js
index 8ad0fd2..41b0b16 100644
--- a/smart-hut/src/components/dashboard/devices/Device.js
+++ b/smart-hut/src/components/dashboard/devices/Device.js
@@ -77,60 +77,28 @@ class Device extends React.Component {
           />
         );
       case "motionSensor":
-        return (
-          <Sensor
-            tab={this.props.tab}
-            sceneState={this.props.sceneState}
-            id={this.props.stateOrDevice.id}
-          />
-        );
+        return <Sensor tab={this.props.tab} id={this.props.stateOrDevice.id} />;
       case "buttonDimmer":
         return (
-          <ButtonDimmer
-            tab={this.props.tab}
-            sceneState={this.props.sceneState}
-            id={this.props.stateOrDevice.id}
-          />
+          <ButtonDimmer tab={this.props.tab} id={this.props.stateOrDevice.id} />
         );
       case "knobDimmer":
         return (
-          <KnobDimmer
-            tab={this.props.tab}
-            sceneState={this.props.sceneState}
-            id={this.props.stateOrDevice.id}
-          />
+          <KnobDimmer tab={this.props.tab} id={this.props.stateOrDevice.id} />
         );
       case "smartPlug":
         return (
-          <SmartPlug
-            tab={this.props.tab}
-            sceneState={this.props.sceneState}
-            id={this.props.stateOrDevice.id}
-          />
+          <SmartPlug tab={this.props.tab} id={this.props.stateOrDevice.id} />
         );
       case "switch":
         return (
-          <Switcher
-            tab={this.props.tab}
-            sceneState={this.props.sceneState}
-            id={this.props.stateOrDevice.id}
-          />
+          <Switcher tab={this.props.tab} id={this.props.stateOrDevice.id} />
         );
       case "dimmableLight":
-        return (
-          <Light
-            id={this.props.stateOrDevice.id}
-            sceneState={this.props.sceneState}
-            tab={this.props.tab}
-          />
-        );
+        return <Light id={this.props.stateOrDevice.id} tab={this.props.tab} />;
       case "securityCamera":
         return (
-          <Videocam
-            id={this.props.stateOrDevice.id}
-            sceneState={this.props.sceneState}
-            tab={this.props.tab}
-          />
+          <Videocam id={this.props.stateOrDevice.id} tab={this.props.tab} />
         );
       default:
         //throw new Error("Device type unknown");
@@ -171,11 +139,12 @@ class Device extends React.Component {
                 </Grid.Column>
               ) : (
                 <Grid.Column textAlign="center">
-                  <Header as="h3">
-                    {this.props.stateOrDevice
-                      ? this.props.stateOrDevice.name
-                      : ""}
-                  </Header>
+                  <Header as="h3">{this.props.device.name}</Header>
+                  {this.props.tab === "Scenes" ? (
+                    <Header as="h4">{this.props.roomName}</Header>
+                  ) : (
+                    ""
+                  )}
                   <Button
                     color="red"
                     icon
@@ -188,6 +157,14 @@ class Device extends React.Component {
                 </Grid.Column>
               )}
             </Grid>
+            {this.props.stateOrDevice ? (
+              <DeviceSettingsModal
+                ref={this.modalRef}
+                id={this.props.stateOrDevice.id}
+              />
+            ) : (
+              ""
+            )}
           </Segment>
         );
       } else {
@@ -211,23 +188,22 @@ const mapStateToProps = (state, ownProps) => ({
     if (state.active.activeTab === "Devices") {
       return state.devices[ownProps.id];
     } else {
-      /*console.log(
-        state.sceneStates,
-        ownProps.id,
-        state.sceneStates[ownProps.id]
-      );*/
       return state.sceneStates[ownProps.id];
     }
   },
-  get sceneState() {
-    if (state.active.activeTab === "Scenes") {
-      const array = [
-        ...state.scenes[state.active.activeScene].sceneStates,
-      ].sort();
-      const deviceState = array.filter((e) => e.id === ownProps.id)[0];
-      return deviceState;
+  get device() {
+    if (state.active.activeTab === "Devices") {
+      return state.devices[ownProps.id];
     } else {
-      return null;
+      return state.devices[state.sceneStates[ownProps.id].deviceId];
+    }
+  },
+  get roomName() {
+    if (state.active.activeTab === "Scenes") {
+      const device = state.devices[state.sceneStates[ownProps.id].deviceId];
+      return state.rooms[device.roomId].name;
+    } else {
+      return "";
     }
   },
   get type() {
diff --git a/smart-hut/src/components/dashboard/devices/DeviceSettingsModal.js b/smart-hut/src/components/dashboard/devices/DeviceSettingsModal.js
index ebb2d91..162e242 100644
--- a/smart-hut/src/components/dashboard/devices/DeviceSettingsModal.js
+++ b/smart-hut/src/components/dashboard/devices/DeviceSettingsModal.js
@@ -66,6 +66,7 @@ class DeviceSettingsModal extends Component {
     super(props);
     this.state = {
       open: false,
+      name: this.props.device.name,
     };
 
     this.updateDevice = this.updateDevice.bind(this);
@@ -111,8 +112,7 @@ class DeviceSettingsModal extends Component {
         <Modal.Header>Settings of {this.props.device.name}</Modal.Header>
         <Modal.Content>
           <SettingsForm
-            name={this.props.device.name}
-            type={this.props.device.type}
+            name={this.state.name}
             removeDevice={this.deleteDevice}
             saveFunction={this.updateDevice}
           />
diff --git a/smart-hut/src/components/dashboard/devices/Light.js b/smart-hut/src/components/dashboard/devices/Light.js
index 0c46282..32786ce 100644
--- a/smart-hut/src/components/dashboard/devices/Light.js
+++ b/smart-hut/src/components/dashboard/devices/Light.js
@@ -118,8 +118,8 @@ class Light extends Component {
         .catch((err) => console.error("regular light update error", err));
     } else {
       this.props.updateState(
-        { id: this.props.sceneState.id, intensity: intensity },
-        this.props.sceneState.kind
+        { id: this.props.stateOrDevice.id, intensity: intensity },
+        this.props.stateOrDevice.kind
       );
     }
   };
diff --git a/smart-hut/src/components/dashboard/devices/Sensor.js b/smart-hut/src/components/dashboard/devices/Sensor.js
index 8592420..ad80a4c 100644
--- a/smart-hut/src/components/dashboard/devices/Sensor.js
+++ b/smart-hut/src/components/dashboard/devices/Sensor.js
@@ -73,13 +73,16 @@ class Sensor extends Component {
       this.props.stateOrDevice.kind === "motionSensor" &&
       this.props.stateOrDevice.detected !== prevProps.stateOrDevice.detected
     ) {
-      this.setState({ motion: true, detected: this.props.stateOrDevice.detected });
+      this.setState({
+        motion: true,
+        detected: this.props.stateOrDevice.detected,
+      });
     }
   }
 
   componentDidMount() {
     if (this.props.stateOrDevice.kind === "sensor") {
-      switch (this.props.device.sensor) {
+      switch (this.props.stateOrDevice.sensor) {
         case "TEMPERATURE":
           this.units = "ºC";
           this.colors = temperatureSensorColors;
@@ -192,10 +195,10 @@ class Sensor extends Component {
 }
 
 const mapStateToProps = (state, ownProps) => ({
-  get stateOrDevice(){
-    if(state.active.activeTab==="Devices"){
+  get stateOrDevice() {
+    if (state.active.activeTab === "Devices") {
       return state.devices[ownProps.id];
-    }else{
+    } else {
       return state.sceneStates[ownProps.id];
     }
   },
diff --git a/smart-hut/src/components/dashboard/devices/SmartPlug.js b/smart-hut/src/components/dashboard/devices/SmartPlug.js
index e1099fa..c14773c 100644
--- a/smart-hut/src/components/dashboard/devices/SmartPlug.js
+++ b/smart-hut/src/components/dashboard/devices/SmartPlug.js
@@ -33,12 +33,15 @@ class SmartPlug extends Component {
 
   onClickDevice = () => {
     const on = !this.turnedOn;
-    if(this.props.tab==="Devices"){
+    if (this.props.tab === "Devices") {
       this.props
-          .saveDevice({ ...this.props.stateOrDevice, on })
-          .catch((err) => console.error("smart plug update error", err));
-    }else{
-      this.props.updateState({ id: this.props.sceneState.id, on: on},this.props.sceneState.kind);
+        .saveDevice({ ...this.props.stateOrDevice, on })
+        .catch((err) => console.error("smart plug update error", err));
+    } else {
+      this.props.updateState(
+        { id: this.props.stateOrDevice.id, on: on },
+        this.props.stateOrDevice.kind
+      );
     }
   };
 
@@ -68,10 +71,10 @@ class SmartPlug extends Component {
 }
 
 const mapStateToProps = (state, ownProps) => ({
-  get stateOrDevice(){
-    if(state.active.activeTab==="Devices"){
+  get stateOrDevice() {
+    if (state.active.activeTab === "Devices") {
       return state.devices[ownProps.id];
-    }else{
+    } else {
       return state.sceneStates[ownProps.id];
     }
   },
diff --git a/smart-hut/src/components/dashboard/devices/Thermostats.js b/smart-hut/src/components/dashboard/devices/Thermostats.js
index d66e6ae..7e5bdf0 100644
--- a/smart-hut/src/components/dashboard/devices/Thermostats.js
+++ b/smart-hut/src/components/dashboard/devices/Thermostats.js
@@ -70,8 +70,8 @@ class Thermostats extends Component {
         .catch((err) => console.error("thermostat update error", err));
     } else {
       this.props.updateState(
-        { id: this.props.sceneState.id, turnOn: turnOn },
-        this.props.sceneState.kind
+        { id: this.props.stateOrDevice.id, turnOn: turnOn },
+        this.props.stateOrDevice.kind
       );
     }
   }
@@ -84,8 +84,8 @@ class Thermostats extends Component {
         .catch((err) => console.error("thermostat update error", err));
     } else {
       this.props.updateState(
-        { id: this.props.sceneState.id, on: on },
-        this.props.sceneState.kind
+        { id: this.props.stateOrDevice.id, on: on },
+        this.props.stateOrDevice.kind
       );
     }
   };
@@ -98,8 +98,11 @@ class Thermostats extends Component {
         .catch((err) => console.error("thermostat update error", err));
     } else {
       this.props.updateState(
-        { id: this.props.sceneState.id, targetTemperature: targetTemperature },
-        this.props.sceneState.kind
+        {
+          id: this.props.stateOrDevice.id,
+          targetTemperature: targetTemperature,
+        },
+        this.props.stateOrDevice.kind
       );
     }
   }
@@ -130,10 +133,10 @@ class Thermostats extends Component {
     } else {
       this.props.updateState(
         {
-          id: this.props.sceneState.id,
+          id: this.props.stateOrDevice.id,
           internalSensorTemperature: internalSensorTemperature,
         },
-        this.props.sceneState.kind
+        this.props.stateOrDevice.kind
       );
     }
   }
diff --git a/smart-hut/src/remote.js b/smart-hut/src/remote.js
index 06de6c9..5f4f49c 100644
--- a/smart-hut/src/remote.js
+++ b/smart-hut/src/remote.js
@@ -418,7 +418,7 @@ export const RemoteService = {
       let url = `/scene/${id}/apply`;
 
       return Endpoint.post(url)
-        .then((res) => dispatch(actions.sceneApply(res.data)))
+        .then((res) => dispatch(actions.deviceOperationUpdate(res.data)))
         .catch((err) => {
           console.warn("scene apply error", err);
           throw new RemoteError(["Network error"]);